Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: Properly install gram.h on MSVC builds

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: Properly install gram.h on MSVC builds
Date: 2011-01-09 16:31:38
Message-ID: 7362.1294590698@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
Magnus Hagander <magnus(at)hagander(dot)net> writes:
> Properly install gram.h on MSVC builds
> This file is now needed by pgAdmin builds, which started
> failing since it was missing in the installer builds.

I'd like to protest this patch as misguided.  AFAICS it is a *seriously*
bad idea for pgAdmin to be including gram.h --- we don't even want most
of the backend to include that, let alone external pieces of code.  It's
not stable enough.  See the note in gramparse.h.

To my way of thinking, not installing that file is a fine idea.
What we really need to be asking is why the pgAdmin folks think
they should be including it.

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Magnus HaganderDate: 2011-01-09 16:35:28
Subject: Re: [COMMITTERS] pgsql: Properly install gram.h on MSVC builds
Previous:From: Heikki LinnakangasDate: 2011-01-09 14:57:14
Subject: Re: SSI patch(es)

pgsql-committers by date

Next:From: Magnus HaganderDate: 2011-01-09 16:35:28
Subject: Re: [COMMITTERS] pgsql: Properly install gram.h on MSVC builds
Previous:From: Magnus HaganderDate: 2011-01-09 16:05:02
Subject: pgsql: Ensure the directory for gram.h is created on win32

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group