Skip site navigation (1) Skip section navigation (2)

Re: Simplify formatting.c

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Euler Taveira de Oliveira <euler(at)timbira(dot)com>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Simplify formatting.c
Date: 2008-05-20 23:09:37
Message-ID: 7221.1211324977@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
Euler Taveira de Oliveira <euler(at)timbira(dot)com> writes:
> Tom Lane wrote:
>> Also, it seems a bit inconsistent to be relying on
>> oracle_compat.c for upper/lower but not initcap.
>> 
> I saw this inconsistence while I'm doing the patch. What about moving 
> that upper/lower/initcap and wcs* code to another file. pg_locale.c? 

That doesn't seem a particularly appropriate place for them.  pg_locale
is about dealing with the locale state, not about doing actual
operations based on the locale data.

I was just thinking of having oracle_compat expose an initcap routine.

			regards, tom lane

In response to

Responses

pgsql-patches by date

Next:From: Tom LaneDate: 2008-05-20 23:14:15
Subject: Re: Map forks (WIP)
Previous:From: Heikki LinnakangasDate: 2008-05-20 21:05:06
Subject: Re: Map forks (WIP)

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group