Skip site navigation (1) Skip section navigation (2)

Re: Not to to confusing

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Greg Sabino Mullane" <greg(at)turnstep(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Not to to confusing
Date: 2005-04-12 05:28:31
Message-ID: 7193.1113283711@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
"Greg Sabino Mullane" <greg(at)turnstep(dot)com> writes:
>         else if (pg_strcasecmp(prev4_wd, "TABLE") == 0 &&
> !                        pg_strcasecmp(prev2_wd, "RENAME") == 0 &&
> !                                        pg_strcasecmp(prev_wd, "TO"))
>                 COMPLETE_WITH_CONST("TO");

In order to be somewhat consistent and not too confusing, could we
spell that as 'pg_strcasecmp(prev_wd, "TO") != 0' please?

(See previous rant about the undesirability of pretending that
integers are booleans...)

			regards, tom lane

In response to

pgsql-patches by date

Next:From: Tom LaneDate: 2005-04-12 05:59:46
Subject: Re: Remove unneeded left joins from psql
Previous:From: Greg Sabino MullaneDate: 2005-04-12 03:05:06
Subject: Not to to confusing

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group