| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
| Cc: | yamt <yamt(at)mwd(dot)biglobe(dot)ne(dot)jp>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [BUGS] BUG #6218: TRAP: FailedAssertion( "!(owner->nsnapshots == 0)", File: "resowner.c", Line: 365) |
| Date: | 2011-09-27 00:43:45 |
| Message-ID: | 7135.1317084225@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> To be honest, I panicked for a second when I saw the new
> SnapshotResetXmin call, before I realized that it wasn't necessary
> before. The serializable case makes more sense the patched way, I
> think.
Yeah, in the old coding, SnapshotResetXmin would have happened
implicitly at the last UnregisterSnapshot call. In this arrangement,
the "last UnregisterSnapshot" is going to be the manual one in
AtEOXact_Snapshot, so we need a manual SnapshotResetXmin there too.
I chose to put it at the bottom of the routine so that it's guaranteed
to fire even if the RegisteredSnapshots count was corrupted, but that's
just paranoia.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2011-09-27 00:46:57 | Re: pg 9.1.1 - ERROR: could not find pathkey item to sort |
| Previous Message | bricklen | 2011-09-27 00:37:45 | pg 9.1.1 - ERROR: could not find pathkey item to sort |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2011-09-27 00:49:51 | Re: bug of recovery? |
| Previous Message | Alvaro Herrera | 2011-09-27 00:33:03 | Re: [BUGS] BUG #6218: TRAP: FailedAssertion( "!(owner->nsnapshots == 0)", File: "resowner.c", Line: 365) |