Skip site navigation (1) Skip section navigation (2)

Re: Re: [COMMITTERS] pgsql: Support comments on FOREIGN DATA WRAPPER and SERVER objects.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Shigeru HANADA <hanada(at)metrosystems(dot)co(dot)jp>, Shigeru Hanada <shigeru(dot)hanada(at)gmail(dot)com>, Thom Brown <thom(at)linux(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: [COMMITTERS] pgsql: Support comments on FOREIGN DATA WRAPPER and SERVER objects.
Date: 2011-04-05 18:47:51
Message-ID: 7102.1302029271@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Tue, Apr 5, 2011 at 6:03 AM, Shigeru HANADA
> <hanada(at)metrosystems(dot)co(dot)jp> wrote:
>> * The comment_user_mapping_core.patch includes syntax support, catalog
>> manipulation, pg_dump support, documents and regression tests.

> I don't think it's going to fly to add a function
> pg_usermapping_ownercheck() with a randomly different API than all the
> parallel functions for other object types.  There is probably some
> more refactoring that needs to be done here to make this sane, but I'm
> coming around to the view that trying to slip this into 9.1 is not the
> best thing for us to be spending time on, especially considering that
> it doesn't seem to be straightforward to figure out how it should
> actually work.  I am inclined to punt this to 9.2.

I agree --- this can clearly contains more worms than we expected.

Supporting user mappings in COMMENT, EXTENSION, etc is not so critical
that we should push a possibly misdesigned notion of ownership into
the system for it.  Better to take our time and think about that.

(BTW, it might be useful to reconsider casts while we are thinking about
this.  Those don't have a proper notion of ownership either.  I'm a bit
inclined to think that we should just bite the bullet and add owner
columns to both these catalogs.  But, again, let's not be hasty.)

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Peter EisentrautDate: 2011-04-05 18:48:55
Subject: Re: [HACKERS] Uppercase SGML entity declarations
Previous:From: Alvaro HerreraDate: 2011-04-05 18:34:54
Subject: Re: [HACKERS] Uppercase SGML entity declarations

pgsql-committers by date

Next:From: Robert HaasDate: 2011-04-05 19:17:35
Subject: pgsql: Repair some flakiness in CheckTargetForConflictsIn.
Previous:From: Alvaro HerreraDate: 2011-04-05 18:06:49
Subject: pgsql: Change "Id" to "id" in some SGML tags

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group