Skip site navigation (1) Skip section navigation (2)

Re: unknown conversion %m

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: unknown conversion %m
Date: 2011-04-27 04:50:47
Message-ID: 7051.1303879847@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackers
Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> All or almost all the warnings seen on Windows/Mingw of the type 
> "warning: unknown conversion type character 'm' in format" come from 
> checking of three functions: errmsg, elog and errdetail. I therefore 
> propose to disable the attribute checking of those three functions, on 
> Windows only (since that's the only place I've seen the warnings). 
> That's a much more conservative change than I made previously which 
> would have turned off all format warnings on Mingw, and along with 
> fixing the INT64_FORMAT (see email just sent) would fix the vast 
> majority of compiler warnings, so we'd be almost clean again on MinGW.

That seems to me to be throwing the baby out with the bathwater.
If Windows could be assumed to be just like every other platform,
we could maybe figure that being format-warning-free elsewhere
was sufficient checking; but that assumption is obviously wrong.

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2011-04-27 04:57:34
Subject: Re: offline consistency check and info on attributes
Previous:From: Andrew DunstanDate: 2011-04-27 04:11:15
Subject: unknown conversion %m

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group