I think I see the real issue behind the recent argument about the
datatype of the timezone variable. I don't think the datatype matters,
but the name certainly does. In pgtz.c we have
#error No way to determine TZ? Can this happen?
but the symbol HAVE_UNDERSCORE_TIMEZONE appears nowhere else ---
certainly it's not set by configure, and never has been. So the
"_timezone" case is dead code at the moment.
In 7.4, pg_config_manual.h contained
* Define this if your operating system has _timezone rather than timezone
#if defined(__CYGWIN__) || defined(WIN32)
#define HAVE_INT_TIMEZONE /* has int _timezone */
#define HAVE_UNDERSCORE_TIMEZONE 1
but this passage has disappeared from CVS tip. So given a platform that
has "_timezone" but not "timezone", CVS tip is broken.
I am wondering how changing this would affect the existing, allegedly
working Windows port. Should we put back the pg_config_manual.h entry?
Should we restrict it to __CYGWIN__ only?
regards, tom lane
pgsql-hackers by date
|Next:||From: Hannu Krosing||Date: 2004-09-01 15:34:32|
|Subject: Re: version upgrade|
|Previous:||From: G u i d o B a r o s i o||Date: 2004-09-01 15:07:39|
|Subject: Re: slower every day|
pgsql-hackers-win32 by date
|Next:||From: Vidyasagara Guntaka||Date: 2004-09-01 18:15:09|
|Subject: Linking Win32 applications with libpq|
|Previous:||From: Philip Warner||Date: 2004-09-01 12:52:12|
|Subject: Re: open item: tablespace handing in|