Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] pgxs/windows

From: "Rocco Altier" <RoccoA(at)Routescape(dot)com>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>,"Bruce Momjian" <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: "Andrew Dunstan" <andrew(at)dunslane(dot)net>,"Magnus Hagander" <mha(at)sollentuna(dot)net>,"PostgreSQL-patches" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] pgxs/windows
Date: 2006-01-19 22:11:12
Message-ID: 6E0907A94904D94B99D7F387E08C4F57B52154@FALCON.INSIGHT (view raw or flat)
Thread:
Lists: pgsql-patches
If I understand correctly, atleast for the AIX case, the reason that
Makefile.aix is referencing DESTDIR is for the PGXS case.

I thought that PGXS was supposed to be able to be run after things were
installed, and you might not have the compile tree anymore.  Basically,
if you wanted to build some extensions on top of a precompiled set of
binaries.

If we take the DESTDIR out of here, where should we get the POSTGRES_IMP
file from?

	-rocco

> -----Original Message-----
> From: pgsql-patches-owner(at)postgresql(dot)org 
> [mailto:pgsql-patches-owner(at)postgresql(dot)org] On Behalf Of Tom Lane
> Sent: Thursday, January 19, 2006 3:54 PM
> To: Bruce Momjian
> Cc: Andrew Dunstan; Magnus Hagander; PostgreSQL-patches
> Subject: Re: [PATCHES] [HACKERS] pgxs/windows 
> 
> 
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > Tom Lane wrote:
> >> What about the question of whether $(DESTDIR) belongs there or not?
> >> I think we had concluded that PGXS shouldn't ever use $(DESTDIR),
> >> because that's only for install-time stuff.
> 
> > I considered that a separate issue and didn't explore it, 
> but I think
> > you are right that $(DESTDIR) makes no sense so I will remove it.
> 
> > Patch attached.
> 
> If these are bogus then so are the uses in Makefile.aix and
> Makefile.darwin.
> 
> I'm a bit bothered by the ones in pgxs.mk, too, although I suspect we
> have to leave those there for the benefit of contrib?
> 
> 			regards, tom lane
> 
> ---------------------------(end of 
> broadcast)---------------------------
> TIP 5: don't forget to increase your free space map settings
> 

Responses

pgsql-patches by date

Next:From: Jim C. NasbyDate: 2006-01-19 22:38:43
Subject: Re: Uninstall scripts for contrib
Previous:From: Bruce MomjianDate: 2006-01-19 21:21:16
Subject: Re: [HACKERS] pgxs/windows

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group