Skip site navigation (1) Skip section navigation (2)

Re: Proposal for Allow postgresql.conf values to be changed via SQL

From: Amit kapila <amit(dot)kapila(at)huawei(dot)com>
To: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Cc: "'Dimitri Fontaine'" <dimitri(at)2ndQuadrant(dot)fr>, "'Tom Lane'"<tgl(at)sss(dot)pgh(dot)pa(dot)us>, "'Fujii Masao'" <masao(dot)fujii(at)gmail(dot)com>, "cedric(at)2ndquadrant(dot)com" <cedric(at)2ndquadrant(dot)com>, "'Robert Haas'"<robertmhaas(at)gmail(dot)com>, "'Greg Smith'" <greg(at)2ndquadrant(dot)com>, "'Josh Berkus'"<josh(at)agliodbs(dot)com>, "'Magnus Hagander'" <magnus(at)hagander(dot)net>, "'Christopher Browne'" <cbbrowne(at)gmail(dot)com>, "'Alvaro Herrera'" <alvherre(at)2ndquadrant(dot)com>
Subject: Re: Proposal for Allow postgresql.conf values to be changed via SQL
Date: 2012-11-22 12:38:42
Message-ID: 6C0B27F7206C9E4CA54AE035729E9C383BC78FCB@szxeml509-mbx (view raw or flat)
Thread:
Lists: pgsql-hackers
On Tuesday, November 20, 2012 7:21 PM Amit Kapila wrote:
On Monday, November 19, 2012 9:07 PM Amit Kapila wrote:
> On Monday, November 19, 2012 8:36 PM Alvaro Herrera wrote:
> > Amit Kapila escribió:
> >
> > > The only point I can see against SET PERSISTENT is that other
> variants
> > of
> > > SET command can be used in
> > > transaction blocks means for them ROLLBACK TO SAVEPOINT
> functionality
> > works,
> > > but for SET PERSISTENT,
> > > it can't be done.
> > > So to handle that might be we need to mention this point in User
> > Manual, so
> > > that users can be aware of this usage.
> > > If that is okay, then I think SET PERSISTENT is good to go.
> >
> > I think that's okay.  There are other commands which have some forms
> > that can run inside a transaction block and others not.  CLUSTER is
> > one example (maybe the only one?  Not sure).
>

> If no objections to SET PERSISTENT .. syntax, I shall update the patch for
> implementation of same.

Patch to implement SET PERSISTENT command is attached with this mail. 
Now it can be reviewed.

I have not update docs, as I want feedback about the behaviour of implementation, so that docs can be updated appropriately.

With Regards,
Amit Kapila.

Attachment: set_persistent.v1.patch
Description: application/octet-stream (24.8 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Alvaro HerreraDate: 2012-11-22 13:03:27
Subject: Re: auto_explain WAS: RFC: Timing Events
Previous:From: Andrew DunstanDate: 2012-11-22 12:36:46
Subject: Re: WIP json generation enhancements

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group