Skip site navigation (1) Skip section navigation (2)

Re: Adminpack build fix

From: "Magnus Hagander" <mha(at)sollentuna(dot)net>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: <pgsql-hackers(at)postgresql(dot)org>, <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Adminpack build fix
Date: 2006-10-19 17:49:41
Message-ID: 6BCB9D8A16AC4241919521715F4D8BCEA0FC91@algol.sollentuna.se (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
> >> The reason for redeclaring these in the contrib files is to get 
> >> DLLIMPORT onto them...
> 
> > Interedting - it builds on MSVC without it :-O
> 
> > Anyway. That certainly explains why MSVC is complaining - 
> it's getting 
> > completely different definitions of these variables from the header 
> > and from the actual file.
> 
> The same redeclaration technique is being used elsewhere 
> (pg_buffercache and pg_freespacemap it looks like).  Aren't 
> you getting warnings there too?

I am - I just started working on getting those done as well. (they were
also living on my list of fix-later ones for some other reasons - the
other reasons now having been fixed)

//Magnus

In response to

Responses

pgsql-hackers by date

Next:From: Magnus HaganderDate: 2006-10-19 17:52:06
Subject: CVS repository rsync
Previous:From: Magnus HaganderDate: 2006-10-19 17:49:00
Subject: qsort vs MSVC build

pgsql-patches by date

Next:From: Tom LaneDate: 2006-10-19 17:57:23
Subject: Re: Adminpack build fix
Previous:From: Tom LaneDate: 2006-10-19 17:47:21
Subject: Re: Adminpack build fix

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group