Skip site navigation (1) Skip section navigation (2)

Re: MSVC build broken (again)

From: "Magnus Hagander" <mha(at)sollentuna(dot)net>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, <pgsql-hackers(at)postgresql(dot)org>
Cc: <pgsql-patches(at)postgresql(dot)org>
Subject: Re: MSVC build broken (again)
Date: 2006-10-03 20:13:20
Message-ID: 6BCB9D8A16AC4241919521715F4D8BCEA0FC1A@algol.sollentuna.se (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
> > The code around errcode is definitly messy. In CVS now, it actually 
> > renames *our* errcode() function to __msvc_errcode, and 
> exports this 
> > from postgres.exe. This is definitly very borken.
> 
> Would it be possible to move the whole <crtdefs.h> block into win32.h?
> This would cause it to be included after <stdio.h> and 
> friends, which maybe is too late, but taking it out of c.h 
> would be a lot cleaner.

Nope, it needs to go before <stdio.h> and friends, unfortunatly.

//Magnus

In response to

Responses

pgsql-hackers by date

Next:From: Zdenek KotalaDate: 2006-10-03 20:31:20
Subject: Re: [PATCHES] Generic Monitoring Framework with DTrace patch
Previous:From: Zdenek KotalaDate: 2006-10-03 20:06:37
Subject: Re: PG qsort vs. Solaris

pgsql-patches by date

Next:From: Zdenek KotalaDate: 2006-10-03 20:31:20
Subject: Re: [PATCHES] Generic Monitoring Framework with DTrace patch
Previous:From: Magnus HaganderDate: 2006-10-03 20:01:31
Subject: Re: vcbuild bison check

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group