| From: | "Magnus Hagander" <mha(at)sollentuna(dot)net> |
|---|---|
| To: | <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Bad bug in fopen() wrapper code |
| Date: | 2006-09-24 14:39:22 |
| Message-ID: | 6BCB9D8A16AC4241919521715F4D8BCEA0FBD3@algol.sollentuna.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
There is a small bug in the fopen() wrapper code that was applied a
couple of weeks back for win32. It sets the wrong flags for files opened
in "append" mode. This makes the logfile writing not work - syslog.c
opens the logfile in append mode, but if the file does not already
exist, it will not be opened and an error is returned - causing the
postmaster to terminate.
This is pretty bad and pretty urgent - with this, systems installed by
the MSI installer simply *do not start*, because they are by default
configured to write logs to a file...
Attached patch sets the O_CREAT option when appending to files.
//Ma <<open.diff>> gnus
| Attachment | Content-Type | Size |
|---|---|---|
| open.diff | application/octet-stream | 763 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2006-09-24 15:14:22 | pg_regress starting postmaster |
| Previous Message | Magnus Hagander | 2006-09-24 14:34:43 | Logfile created when not needed? |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2006-09-24 15:28:37 | pg_ctl error msg on Windows 2000 |
| Previous Message | Tom Lane | 2006-09-22 16:21:16 | Re: Timezone doc patch |