Skip site navigation (1) Skip section navigation (2)

Re: Tiny plpython fix

From: "Magnus Hagander" <mha(at)sollentuna(dot)net>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, <pgsql-hackers(at)postgresql(dot)org>
Cc: <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Tiny plpython fix
Date: 2006-09-16 11:56:04
Message-ID: 6BCB9D8A16AC4241919521715F4D8BCEA0FBA8@algol.sollentuna.se (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
> > Seems __vc_errcode was used during Visual C++ beta at some 
> point, and 
> > is now declared deprecated in the system headers. This 
> patch renames 
> > our use of it to __msvc_errcode, so we don't conflict anymore.
> 
> If we need this change in plpython, why not also 
> src/include/port/win32.h?

That's a very good question. It is because something that's pulled in
from the python headers causes the deprecation to show. Whereas when we
compile other things, the deprecation is hidden somewhere in an #ifdef
or so. But its definitly not *wrong* to fix it in win32.h as well.

The level of header files can be quite horrible to find this in, so I
haven't dug deep enough to find exactly which define it comes from. But
given that it's somewhere in the python headers, it's not something we
can change anyway.

//Magnus

In response to

Responses

pgsql-hackers by date

Next:From: Guillaume SmetDate: 2006-09-16 11:56:35
Subject: Re: log_duration is redundant, no?
Previous:From: Magnus HaganderDate: 2006-09-16 11:37:42
Subject: Re: [PATCHES] pg_strcasecmp in fe-connect.c

pgsql-patches by date

Next:From: Magnus HaganderDate: 2006-09-16 12:00:37
Subject: Re: [PATCHES] Include file in regress.c
Previous:From: Magnus HaganderDate: 2006-09-16 11:37:42
Subject: Re: [PATCHES] pg_strcasecmp in fe-connect.c

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group