| From: | "Magnus Hagander" <mha(at)sollentuna(dot)net> |
|---|---|
| To: | "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCHES] pg_strcasecmp in fe-connect.c |
| Date: | 2006-09-16 11:37:42 |
| Message-ID: | 6BCB9D8A16AC4241919521715F4D8BCEA0FBA7@algol.sollentuna.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
> > This patch fixes a couple of cases where we use
> strcasecmp() instead
> > of
> > pg_strcasecmp() in fe_connect.c, coming from the LDAP client pathc.
>
> Applied. I found another instance in contrib/hstore, too.
Ah. msvc builds don't currently build /contrib, that's why I missed that
one.
> There are also some occurrences in pgbench.c, but I'm unsure
> that we need be paranoid about changing those.
If we ever want to be able to compile it on a platform that doesn't have
strcasecmp() (such as MSVC++), we would, no?
//Magnus
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2006-09-16 11:56:04 | Re: Tiny plpython fix |
| Previous Message | Nicolas Barbier | 2006-09-16 09:34:25 | Re: Optimize ORDER BY ... LIMIT |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2006-09-16 11:56:04 | Re: Tiny plpython fix |
| Previous Message | Bruce Momjian | 2006-09-15 23:08:59 | Re: wrong behavior using to_char() |