From: | "Magnus Hagander" <mha(at)sollentuna(dot)net> |
---|---|
To: | "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Andrew Dunstan" <andrew(at)dunslane(dot)net> |
Cc: | "PostgreSQL-development" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: windows / initdb oddness |
Date: | 2006-02-22 17:21:22 |
Message-ID: | 6BCB9D8A16AC4241919521715F4D8BCE6C8068@algol.sollentuna.se |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> > Thinking about this a tiny bit more, it struck me that by
> far the best
> > way to do this is to stop using a magic argument and use the
> > environment instead. Then we don't need to mangle the
> command line at
> > all. This actually results in less code, and should be more robust
> > (mangling the command line in Windows is dangerous and
> difficult because of quotes).
>
> This seems like a good idea.
>
> Is there any reason to worry about an accidental environment conflict?
> If someone mistakenly did "export PG_RESTRICT_EXEC=1", it
> looks to me like this would cause the re-exec bit to be
> skipped, but I suppose the worst possible consequence is that
> the postmaster would refuse to start.
> Is there anything I don't see? (Of course, the magic
> argument method can be broken manually in just the same way...)
This only affects initdb, not postmaster.
I don't see the risk being bigger with environment than commandline at
all.
//Magnus
From | Date | Subject | |
---|---|---|---|
Next Message | Magnus Hagander | 2006-02-22 17:22:58 | Re: windows / initdb oddness |
Previous Message | Stephan Szabo | 2006-02-22 17:14:40 | Re: pg_config, pg_service.conf, postgresql.conf .... |