Skip site navigation (1) Skip section navigation (2)

Re: explain analyze timings

From: "Magnus Hagander" <mha(at)sollentuna(dot)net>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: <pgsql-hackers-win32(at)postgresql(dot)org>,"PostgreSQL-patches" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: explain analyze timings
Date: 2005-03-20 18:37:13
Message-ID: 6BCB9D8A16AC4241919521715F4D8BCE6C70EB@algol.sollentuna.se (view raw or flat)
Thread:
Lists: pgsql-hackers-win32pgsql-patches
>> Here's a patch that does just this.
>
>This seems about the ugliest and most intrusive way you could have
>done it :-(.  A judicious typedef and macro or two could eliminate
>most of the #ifdefs and code duplication, thereby preserving
>readability...

Well, I certainly can't argue with that, now that you mention it ;-)
Here is a second attempt, hope it's closer to what you expected.

I still left two #ifdefs in there, for the addition and subtraction of
timeval:s specifically. They could be made functions/macros too, just
not sure if it's worth it.

Tested on win32 and linux (now that it changes non-win32 specific code
as well).

//Magnus

Attachment: win32_instr2.patch
Description: application/octet-stream (8.8 KB)

Responses

pgsql-patches by date

Next:From: Tom LaneDate: 2005-03-20 22:30:20
Subject: Re: explain analyze timings
Previous:From: Andrew DunstanDate: 2005-03-20 18:23:58
Subject: Re: [pgsql-hackers-win32] snprintf causes regression tests

pgsql-hackers-win32 by date

Next:From: Tom LaneDate: 2005-03-20 22:30:20
Subject: Re: explain analyze timings
Previous:From: Andrew DunstanDate: 2005-03-20 18:23:58
Subject: Re: [pgsql-hackers-win32] snprintf causes regression tests

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group