Re: win32 performance - fsync question

From: "Magnus Hagander" <mha(at)sollentuna(dot)net>
To: "Michael Paesold" <mpaesold(at)gmx(dot)at>, "Bruce Momjian" <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, <pgsql-hackers(at)postgresql(dot)org>, <pgsql-hackers-win32(at)postgresql(dot)org>, "Merlin Moncure" <merlin(dot)moncure(at)rcsonline(dot)com>
Subject: Re: win32 performance - fsync question
Date: 2005-02-27 11:26:22
Message-ID: 6BCB9D8A16AC4241919521715F4D8BCE4769D3@algol.sollentuna.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-hackers-win32

>> Patch applied. Thanks.
>>
>> I assume this is not approprate for 8.0.X.
>>
>> ---------------------------------------------------------------
>>
>>
>> Magnus Hagander wrote:
>>> > Magnus prepared a trivial patch which added the O_SYNC flag
>>> > for windows and mapped it to FILE_FLAG_WRITE_THROUGH in
>>> > win32_open.c.
>>>
>>> Attached is this trivial patch. As Merlin says, it needs some more
>>> reliability testing. But the numbers are at least reasonable - it
>>> *seems* like it's doing the right thing (as long as you
>turn off write
>>> cache). And it's certainly a significant performance increase - it
>>> brings the speed almost up to the same as linux.
>
>
>The original patch did not have any documentation. Have you
>added some?
>Since this has to be configured in GUC (wal_sync_method), the
>implications
>should be documented somewhere, no?

The patch just implements behaviour that was already documented (for
unix) on a new platform (win32). The documentation in general appears to
have very little information on what to pick there, though ;-)

//Magnus

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paesold 2005-02-27 13:46:06 Re: win32 performance - fsync question
Previous Message Magnus Hagander 2005-02-27 11:15:13 Re: [pgsql-hackers-win32] win32 performance - fsync question

Browse pgsql-hackers-win32 by date

  From Date Subject
Next Message Michael Paesold 2005-02-27 13:46:06 Re: win32 performance - fsync question
Previous Message Magnus Hagander 2005-02-27 11:15:13 Re: [pgsql-hackers-win32] win32 performance - fsync question