Skip site navigation (1) Skip section navigation (2)

Re: [BUGS] BUG #1466: #maintenace_work_mem = 16384

From: "Magnus Hagander" <mha(at)sollentuna(dot)net>
To: "Bruce Momjian" <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>,"PostgreSQL-patches" <pgsql-patches(at)postgresql(dot)org>,"Andreas Pflug" <pgadmin(at)pse-consulting(dot)de>
Subject: Re: [BUGS] BUG #1466: #maintenace_work_mem = 16384
Date: 2005-02-27 11:11:07
Message-ID: 6BCB9D8A16AC4241919521715F4D8BCE4769CF@algol.sollentuna.se (view raw or flat)
Thread:
Lists: pgsql-patches
Actually, I'd like it considered for 8.0.X as well. Right now if yuo
change the config file in a way that it won't load, you get no error
message. Which is cearly not very good. I'll certainly accept if you
think it's not safe enough for 8.0.x, but please consider it.

//Magnus


>-----Original Message-----
>From: Bruce Momjian [mailto:pgman(at)candle(dot)pha(dot)pa(dot)us] 
>Sent: den 27 februari 2005 02:04
>To: Magnus Hagander
>Cc: Tom Lane; PostgreSQL-patches; Andreas Pflug
>Subject: Re: [PATCHES] [BUGS] BUG #1466: #maintenace_work_mem = 16384
>
>
>
>Patch applied.  Thanks.
>
>I assume this is not for 8.0.X.
>
>---------------------------------------------------------------
>------------
>
>
>Magnus Hagander wrote:
>> >>> The proposed test on Redirect_stderr looks pretty fishy 
>too; for one
>> >>> thing it will almost certainly not be the right thing 
>> >inside the stderr
>> >>> logger subprocess itself.
>> >
>> >> Could you explain further what the issue is there? 
>> >
>> >Inside the logger subprocess, Redirect_stderr is guaranteed 
>true (since
>> >it'll be inherited from the postmaster) and therefore the proposed
>> >change ensures that anything the logger might want to complain about
>> >goes to the original stderr, ie, into the bit bucket rather than
>> >someplace useful.  Perhaps something like
>> >
>> >	if ((!Redirect_stderr || am_syslogger) && pgwin32_is_service())
>> >
>> >would be reasonable.
>> 
>> <snip lots of others>
>> 
>> Here is an updated patch, that should take care of this. 
>Tested that it
>> solves the problem reported.
>> 
>> 
>> >> There is special code in the send_message_to_server_log 
>> >function to make
>> >> sure it's written directly to the file.
>> >
>> >If the logger is complaining, it's quite possibly because it's 
>> >unable to
>> >write to its file.  Now that you mention it, doesn't this 
>code go into
>> >infinite recursion if write_syslogger_file_binary() tries 
>to ereport?
>> >
>> 
>> I haven't looked at this part, it appears a separate (but closely
>> related) issue.
>> 
>> Perhaps Andreas can comment on this?
>> 
>> //Magnus
>
>Content-Description: stderr.patch
>
>[ Attachment, skipping... ]
>
>> 
>> ---------------------------(end of 
>broadcast)---------------------------
>> TIP 5: Have you checked our extensive FAQ?
>> 
>>                http://www.postgresql.org/docs/faq
>
>-- 
>  Bruce Momjian                        |  http://candle.pha.pa.us
>  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 359-1001
>  +  If your life is a hard drive,     |  13 Roberts Road
>  +  Christ can be your backup.        |  Newtown Square, 
>Pennsylvania 19073
>

pgsql-patches by date

Next:From: Bruce MomjianDate: 2005-02-27 15:22:40
Subject: Re: Casting INT4 to BOOL...
Previous:From: Neil ConwayDate: 2005-02-27 08:42:03
Subject: array max() / min()

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group