Re: [HACKERS] src/timezone/pgtz __imp__my_exec_path

> >>beta4 - cygwin:
> >>postgres.exe fails to build, because __imp__my_exec_path from
> >>src/timezone/pgtz.o cannot be resolved. previously it was not
> >>imported.
> >
> > This could be related to the patch that went in last weekend to fix
> > compiles on Win32. DLLIMPORT was added to the header. If
> the Makefile
> > did not change, then that is your problem - that patch
> changed botht
> > he makefile and the header. See
> > http://archives.postgresql.org/pgsql-committers/2004-10/msg00321.php
> >
> > Does CYGWIN perhaps need the same Makefile patch?
>
> You only patched your Makefile.win32, not Makefile.cygwin.
> That's it. It builds fine now.
>
> Please add also
>
> ifneq (,$(findstring timezone,$(subdir))) override CPPFLAGS+=
> -DBUILDING_DLL endif
>
> to the Makefile.cygwin.
> Without it doesn't break just contrib/tsearch, it even breaks
> cygwin postmaster.

Soudns reasonable.

> Maybe all win32.mak and bcc32.mak must also be checked. Does
> anybody do the msvc/borland suites?

Not affected. Only the frontend can be compiled with those, and this is
a backend change.

//Magnus