>> The distutils module has a get_python_inc() function which
>> include directory. If this one was used, we wouldn't have to
>hack up the
>> include path as I do now. Is there any reason this is not
>used on Unix,
>> instead of the hardcoded subdirectory-of-"python_prefix" way
>it is now?
>> (in _PGAC_CHECK_PYTHON_DIRS)
>Probably because until about 2 weeks ago, we didn't check for, or use,
>distutils at all ;-). Now we probably should.
Thanks. That explains a lot :-) Digging a bit further into it, now that
I knew that might be old code, I found that the parts that fail on win32
could be replaced with distutils code which does *not* fail on win32. So
no port-specific hack required at all.
So, here is a new patch. Summary:
* Get python_includespec from distutils instead of assuming directory
* Get python_libspec from distutils instead of manually grep:ing in the
* Export the python version into Makefile.global for access from
* Change plpython/Makefile to generate an import library from the
installed python DLL. Now with comments on what and why. (This is the
only if win32 part left)
Hopefully this is better and more complete than the last attempt. I've
tested it on Linux with python 2.3.3 (slackware 9.1), and the new
autoconf stuff passes both there and on win32.
I know it's close to the wrap-time, but it'd be great if this could get
into beta3 (assuming it's Ok now).
pgsql-patches by date
|Next:||From: Andrew Dunstan||Date: 2004-09-26 19:00:00|
|Subject: Re: [HACKERS] cvsup|
|Previous:||From: Greg Stark||Date: 2004-09-26 06:51:53|
|Subject: Re: How to add locale support for each column?|