| From: | "Magnus Hagander" <mha(at)sollentuna(dot)net> |
|---|---|
| To: | "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | "Steve McWilliams" <smcwilliams(at)EmprisaNetworks(dot)com>, <pgsql-bugs(at)postgresql(dot)org>, <pgsql-hackers-win32(at)postgresql(dot)org>, "PostgreSQL-patches" <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: [PATCHES] [pgsql-hackers-win32] Win32 deadlock detection not working for Postgres8beta1 |
| Date: | 2004-09-07 08:13:53 |
| Message-ID: | 6BCB9D8A16AC4241919521715F4D8BCE475C02@algol.sollentuna.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers-win32 pgsql-patches |
> > [ fix broken CHECK_FOR_INTERRUPTS macro ]
>
> Applied. I see how this might change detection of
> statement_timeout, but I do not actually see what it's got to
> do with deadlock detection.
> In the deadlock situation the process that needs to wake up
> is going to be blocked on a semaphore, and so it's not going
> to be executing CHECK_FOR_INTERRUPTS at all. How does this
> fix that case?
It doesn't. This is why the second version of the patch was required,
per http://archives.postgresql.org/pgsql-patches/2004-09/msg00039.php.
It even specifically says this is so it fixes the deadlock issues and
not just statement_timeout :-)
//Magnus
| From | Date | Subject | |
|---|---|---|---|
| Next Message | PostgreSQL Bugs List | 2004-09-07 08:58:47 | BUG #1243: Driver problem |
| Previous Message | PostgreSQL Bugs List | 2004-09-07 07:57:14 | BUG #1242: Major bug in pgSQL |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2004-09-07 14:32:33 | Re: [PATCHES] [pgsql-hackers-win32] Win32 deadlock detection not working for Postgres8beta1 |
| Previous Message | Tom Lane | 2004-09-06 23:57:42 | Re: [PATCHES] [pgsql-hackers-win32] Win32 deadlock detection not working for Postgres8beta1 |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2004-09-07 14:32:33 | Re: [PATCHES] [pgsql-hackers-win32] Win32 deadlock detection not working for Postgres8beta1 |
| Previous Message | Weiping | 2004-09-07 07:23:26 | Re: fix for pg_dump (caused by array output syntax changes) |