Skip site navigation (1) Skip section navigation (2)

Re: [BUGS] Win32 deadlock detection not working for Postgres8beta1

From: "Magnus Hagander" <mha(at)sollentuna(dot)net>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>,"Steve McWilliams" <smcwilliams(at)EmprisaNetworks(dot)com>
Cc: <pgsql-hackers-win32(at)postgresql(dot)org>,"PostgreSQL-patches" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [BUGS] Win32 deadlock detection not working for Postgres8beta1
Date: 2004-09-02 18:59:34
Message-ID: 6BCB9D8A16AC4241919521715F4D8BCE475BB6@algol.sollentuna.se (view raw or flat)
Thread:
Lists: pgsql-hackers-win32pgsql-patches
>>Bugger. I've found the reason for this - statement_timeout was also
>>broken. This was broken by the change of how signals are handled on
>>win32. We disabled APCs completely, but APCs were still used in the
>>timer emulation... This patch fixes this by re-enabling APCs 
>>in the main
>>check loop. The APC routine used by the timer code is very simple and
>>will not interfer with the signal stuff (which had problems 
>with socket
>>calls, as you probably recall).
>
>
>Sorry, this was a bit premature. There are a few more places that need
>to be cleane dup. I'll send a new patch in a couple of minutes.

Here's a more complete patch that addresses all the places where
WaitForxxx can block. The previous fix only fixed statement_timeout, not
the deadlock situation.

//Magnus

Attachment: win32_timer.patch
Description: application/octet-stream (3.9 KB)

pgsql-patches by date

Next:From: Tom LaneDate: 2004-09-02 19:07:22
Subject: Re: [pgsql-hackers-win32] Win32 deadlock detection not working for Postgres8beta1
Previous:From: Magnus HaganderDate: 2004-09-02 18:51:07
Subject: Re: [BUGS] Win32 deadlock detection not working for Postgres8beta1

pgsql-hackers-win32 by date

Next:From: Tom LaneDate: 2004-09-02 19:07:22
Subject: Re: [pgsql-hackers-win32] Win32 deadlock detection not working for Postgres8beta1
Previous:From: Magnus HaganderDate: 2004-09-02 18:51:07
Subject: Re: [BUGS] Win32 deadlock detection not working for Postgres8beta1

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group