Skip site navigation (1) Skip section navigation (2)

Re: [PATCHES] postmaster.pid

From: "Magnus Hagander" <mha(at)sollentuna(dot)net>
To: "Andrew Dunstan" <andrew(at)dunslane(dot)net>,"Dave Page" <dpage(at)vale-housing(dot)co(dot)uk>
Cc: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>,<pgsql-hackers-win32(at)postgresql(dot)org>,"PostgreSQL-patches" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [PATCHES] postmaster.pid
Date: 2004-08-26 15:07:18
Message-ID: 6BCB9D8A16AC4241919521715F4D8BCE475B38@algol.sollentuna.se (view raw or flat)
Thread:
Lists: pgsql-hackers-win32pgsql-patches
Shouldn't be necessary. We can do it, but it makes no real difference
:-) It just ends up queued, but since there is no signal #0, it will
never get dispatched.

But it certainly wouldn't break things to do it either :-)

//Magnus


> Should we (if only for the sake of completeness) make the 
> converse one-byte change in port/win32/signal.c?
> 
> It says:
> 
> void
> pg_queue_signal(int signum)
> {
>     if (signum >= PG_SIGNAL_COUNT || signum < 0)
>         return;
>  ...
> 
> ISTM we should not ever queue any event for signal 0.
> 
> cheers
> 
> andrew
> 
> 
> Dave Page wrote:
> 
> > 
> >
> >  
> >
> >>-----Original Message-----
> >>From: Magnus Hagander [mailto:mha(at)sollentuna(dot)net]
> >>Sent: 25 August 2004 14:59
> >>To: Tom Lane
> >>Cc: Dave Page; pgsql-hackers-win32(at)postgresql(dot)org
> >>Subject: RE: [pgsql-hackers-win32] postmaster.pid
> >>
> >>Ok, if you say so :-) I had the general impression we 
> wanted that. But 
> >>then let's go with the 
> >>send-signal-0-down-the-pipe-and-ignore-it-in-the-backend. :-)
> >>    
> >>
> >
> >Here's the massive 1 byte change required to do just that :-)
> >
> >Regards, Dave.
> >
> >
> >===================================================================
> >RCS file: /projects/cvsroot/pgsql-server/src/port/kill.c,v
> >retrieving revision 1.2
> >diff -u -r1.2 kill.c
> >--- kill.c	24 Jun 2004 18:53:48 -0000	1.2
> >+++ kill.c	26 Aug 2004 14:07:49 -0000
> >@@ -26,7 +26,7 @@
> > 	BYTE		sigRet = 0;
> > 	DWORD		bytes;
> > 
> >-	if (sig >= PG_SIGNAL_COUNT || sig <= 0)
> >+	if (sig >= PG_SIGNAL_COUNT || sig < 0)
> > 	{
> > 		errno = EINVAL;
> > 		return -1;
> >
> >---------------------------(end of 
> >broadcast)---------------------------
> >TIP 2: you can get off all lists at once with the unregister command
> >    (send "unregister YourEmailAddressHere" to 
> >majordomo(at)postgresql(dot)org)
> >
> >  
> >
> 
> 

pgsql-patches by date

Next:From: Tom LaneDate: 2004-08-26 15:23:39
Subject: Re: [PATCHES] postmaster.pid
Previous:From: Dave PageDate: 2004-08-26 14:59:53
Subject: Re: [PATCHES] postmaster.pid

pgsql-hackers-win32 by date

Next:From: Tom LaneDate: 2004-08-26 15:23:39
Subject: Re: [PATCHES] postmaster.pid
Previous:From: Dave PageDate: 2004-08-26 14:59:53
Subject: Re: [PATCHES] postmaster.pid

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group