Skip site navigation (1) Skip section navigation (2)

Re: [pgsql-hackers-win32] Win32 lost signals open item

From: "Magnus Hagander" <mha(at)sollentuna(dot)net>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Bruce Momjian" <pgman(at)candle(dot)pha(dot)pa(dot)us>,"PostgreSQL-development" <pgsql-hackers(at)postgresql(dot)org>,"PostgreSQL Win32 port list" <pgsql-hackers-win32(at)postgresql(dot)org>
Subject: Re: [pgsql-hackers-win32] Win32 lost signals open item
Date: 2004-11-01 20:38:43
Message-ID: 6BCB9D8A16AC4241919521715F4D8BCE456A3F@algol.sollentuna.se (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-hackers-win32
>> [ proposed fix ]
>> As you can see, this is quite a bit more complicated than the simple
>> CreateProcess() call we have now.
>> ...
>> If this seems like a reasonable approach, I can see if I can get
>> something together. But it's a fairly large change..
>
>It sounds reasonable to me, in the sense that it is a localized change,
>even if rather messy.  (Perhaps this chunk of code should be 
>pushed into
>src/port someplace, instead of being dropped into postmaster.c?)

That's an idea. However, since this has to be tied in with the creationi
of the backend-parameter-file, it's going to have to hit
write_backend_variables() in some way, and have access to postmaster
variables. I think it might be even more messy to push it out.

Basically, I think internal_forkexec() needs to be split up into two -
one win32 and one other. For win32 version, it needs to CreateProcess()
*before* it does write_backend_variables(), and then pass the process id
as a parameter to write_backend_vars().

I think if it should be broken out, we need to break the whole package
of internal_forkexec, read/write_backend_vars, and probably
SubPostmasterMain() out somewhere. Not sure it's worth it.

//Magnus

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2004-11-01 20:47:28
Subject: Re: [pgsql-hackers-win32] Win32 lost signals open item
Previous:From: Tom LaneDate: 2004-11-01 20:24:56
Subject: Re: [pgsql-hackers-win32] Win32 lost signals open item

pgsql-hackers-win32 by date

Next:From: Tom LaneDate: 2004-11-01 20:47:28
Subject: Re: [pgsql-hackers-win32] Win32 lost signals open item
Previous:From: Tom LaneDate: 2004-11-01 20:24:56
Subject: Re: [pgsql-hackers-win32] Win32 lost signals open item

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group