Skip site navigation (1) Skip section navigation (2)

Re: win32 setitimer implementation

From: "Magnus Hagander" <mha(at)sollentuna(dot)net>
To: "Claudio Natoli" <claudio(dot)natoli(at)memetrics(dot)com>,<pgsql-patches(at)postgresql(dot)org>, <pgsql-hackers-win32(at)postgresql(dot)org>
Cc: "Bruce Momjian" <pgman(at)candle(dot)pha(dot)pa(dot)us>
Subject: Re: win32 setitimer implementation
Date: 2004-02-17 21:03:35
Message-ID: 6BCB9D8A16AC4241919521715F4D8BCE34B26C@algol.sollentuna.se (view raw or flat)
Thread:
Lists: pgsql-hackers-win32pgsql-patches
Ok, here's an updated timer.c that fixes these concerns and also adds a
$postgresql$ header to the file.

It also removes the check if value == NULL, since that is now Asserted
instead. And it really should never happen based on the places where
setitimer is used.

The patch stays unchanged, just a new timer.c

//Magnus


>-----Original Message-----
>From: Claudio Natoli [mailto:claudio(dot)natoli(at)memetrics(dot)com] 
>Sent: den 17 februari 2004 12:25
>To: Magnus Hagander; pgsql-patches(at)postgresql(dot)org; 
>pgsql-hackers-win32(at)postgresql(dot)org
>Subject: RE: [pgsql-hackers-win32] win32 setitimer implementation
>
>
>
>
>
>> Here is a patch that implements setitimer() on win32. With 
>this patch 
>> applied, deadlock detection and statement_timeout now works.
>> 
>> The file timer.c goes into src/backend/port/win32/.
>
>Minor comments:
>
>* "timer.c" has shmem.c in header
>* I'd suggest Asserts on the remaining 2 limitations ("zero" 
>it_interval and NULL ovalue), on the off chance that some 
>future change to the source expects them (ie. so we'll find 
>out about it under win32 pretty quickly); possibly provide 
>defines of ITIMER_VIRT and ITIMER_PROF, for completeness.
>
>Looks good,
>Claudio
>
>--- 
>Certain disclaimers and policies apply to all email sent from 
>Memetrics. For the full text of these disclaimers and policies see 
><a 
>href="http://www.memetrics.com/emailpolicy.html">http://www.mem
>etrics.com/em
>ailpolicy.html</a>
>

Attachment: timer.c
Description: application/octet-stream (1.8 KB)

pgsql-patches by date

Next:From: Tom LaneDate: 2004-02-17 22:43:40
Subject: Doing psql's lexing with flex
Previous:From: Claudio NatoliDate: 2004-02-17 11:24:40
Subject: Re: win32 setitimer implementation

pgsql-hackers-win32 by date

Next:From: Dann CorbitDate: 2004-02-18 00:48:21
Subject: Win32 development question
Previous:From: Merlin MoncureDate: 2004-02-17 15:04:31
Subject: more info from the interix port

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group