Skip site navigation (1) Skip section navigation (2)

Re: win32 setitimer implementation

From: "Magnus Hagander" <mha(at)sollentuna(dot)net>
To: "Claudio Natoli" <claudio(dot)natoli(at)memetrics(dot)com>,<pgsql-hackers-win32(at)postgresql(dot)org>
Subject: Re: win32 setitimer implementation
Date: 2004-02-17 14:34:40
Message-ID: 6BCB9D8A16AC4241919521715F4D8BCE34B254@algol.sollentuna.se (view raw or flat)
Thread:
Lists: pgsql-hackers-win32
> > Here is a patch that implements setitimer() on win32. With 
> this patch 
> > applied, deadlock detection and statement_timeout now works.
> > 
> > The file timer.c goes into src/backend/port/win32/.
> 
> Minor comments:
> 
> * "timer.c" has shmem.c in header
Oops. Cut-and-paste shows a bit to clearly there.

> * I'd suggest Asserts on the remaining 2 limitations ("zero" 
> it_interval and NULL ovalue), on the off chance that some 
> future change to the source expects them (ie. so we'll find 
> out about it under win32 pretty quickly);
Ok, will do and send updated patch.

> possibly provide 
> defines of ITIMER_VIRT and ITIMER_PROF, for completeness.
I was thinking specifically not providing it. This way we will find out
*really* fast if somebody adds usage of them - since the compile will
break. Then we add them once they are required.
Otherwise, we always have the risk that if it's added in a
not-often-called-place, it will take a while before anybody picks it up.
Easier to fix right away.


//Magnus

pgsql-hackers-win32 by date

Next:From: Merlin MoncureDate: 2004-02-17 15:04:31
Subject: more info from the interix port
Previous:From: Claudio NatoliDate: 2004-02-17 11:24:40
Subject: Re: win32 setitimer implementation

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group