Skip site navigation (1) Skip section navigation (2)

Re: [PATCHES] Updated win32 readdir patch

From: "Magnus Hagander" <mha(at)sollentuna(dot)net>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: <pgsql-patches(at)postgresql(dot)org>,"pgsql-hackers-win32" <pgsql-hackers-win32(at)postgresql(dot)org>
Subject: Re: [PATCHES] Updated win32 readdir patch
Date: 2004-02-08 22:25:22
Message-ID: 6BCB9D8A16AC4241919521715F4D8BCE34B173@algol.sollentuna.se (view raw or flat)
Thread:
Lists: pgsql-hackers-win32pgsql-patches
>> Here is an updated version of the win32 readdir patch.
>
>> 1) Now puts in exactly the same change as the current-cvs mingw code
>> does. (see
>> 
>>http://cvs.sourceforge.net/viewcvs.py/mingw/runtime/mingwex/dir
ent.c?r1=3D
>> 1.3&r2=3D1.4, second part of the patch).

> I don't really agree with cluttering our code with temporary
workarounds
>for a mingw bug.

Fine by me, as long as we still keep it on the win32 page. It *is*
required to build on win32 (or rather - not to build, but if you build
without it, you will get a runtime failure). 

AFAIK we have no idea when the new mingw will actually be out, but if
it's out before the postgresql version with win32, then we're fine
without it. If not, we can discuss at that time if we want it
temporarily applied or keep it as a temporary patch (since it might at
that point make a big difference for people downloading the distro and
thinking it would work out of the box).


//Magnus

Responses

pgsql-patches by date

Next:From: Simon RiggsDate: 2004-02-08 23:29:47
Subject: Re: [PATCHES] update i386 spinlock for hyperthreading
Previous:From: Tom LaneDate: 2004-02-08 22:17:05
Subject: Re: [PATCHES] Updated win32 readdir patch

pgsql-hackers-win32 by date

Next:From: Jan WieckDate: 2004-02-09 14:33:09
Subject: Re: [HACKERS] Sync vs. fsync during checkpoint
Previous:From: Tom LaneDate: 2004-02-08 22:17:05
Subject: Re: [PATCHES] Updated win32 readdir patch

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group