Skip site navigation (1) Skip section navigation (2)

Re: [PATCHES] win32 signals, part 5

From: "Magnus Hagander" <mha(at)sollentuna(dot)net>
To: "Magnus Hagander" <mha(at)sollentuna(dot)net>,"Neil Conway" <neilc(at)samurai(dot)com>
Cc: <pgsql-patches(at)postgresql(dot)org>,"pgsql-hackers-win32" <pgsql-hackers-win32(at)postgresql(dot)org>,"Claudio Natoli" <claudio(dot)natoli(at)memetrics(dot)com>
Subject: Re: [PATCHES] win32 signals, part 5
Date: 2004-02-06 22:32:06
Message-ID: 6BCB9D8A16AC4241919521715F4D8BCE1715CE@algol.sollentuna.se (view raw or flat)
Thread:
Lists: pgsql-hackers-win32pgsql-patches
>>> Taking into account Claudios comments on the previous patch, 
>>as well as
>>> some more fooling around here of my own, here's a fourth 
>(and final?)
>>> one.
>
>Actually, please hold just a second :-)
>
>I have an updated version of this patch that fixes the remaining small
>issue (FATAL on failure to set the control handler). Will post later
>tonight or early tomorrow.  Only veyr small changes, so if there are no
>objections to this one, there shouldn't be to that one either.

Here's the new one. Turns out I had already fixed the one part I thought
I still had, so it was already ready.

Changes since last patch:

1) Error messages in pgwin32_signal_initialize() are now all using
ereport(). (Previously used fprintf to stderr, but I realised that this
function executes on the main thread and can thus use ereport). The
error for SetConsoleCtrlHandler() is now FATAL, per suggestion from
Claudio.

2) Redefines CHECK_FOR_INTERRUPTS() on Win32 only, to include a call to
WaitForSingleObjectEx(). This allows our signals to be delivered just
before we check for their result. WIth this change, query cancel now
works fine on win32. It's also possible to do an "administrator
shutdown" on a backend that is running a query (previously only possible
when the backend was idle)


The rest is identical to patch _4.

//Magnus

Responses

pgsql-patches by date

Next:From: David GaramondDate: 2004-02-07 18:40:22
Subject: connectby for BYTEA keys
Previous:From: Magnus HaganderDate: 2004-02-06 22:14:12
Subject: Re: [PATCHES] win32 signals, part 4

pgsql-hackers-win32 by date

Next:From: Wei WangDate: 2004-02-06 23:01:38
Subject: Re: Installing postgresql on Windows question
Previous:From: Magnus HaganderDate: 2004-02-06 22:22:27
Subject: Re: Installing postgresql on Windows question

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group