Skip site navigation (1) Skip section navigation (2)

Re: Result Set Cursor Patch

From: Andy Zeneski <jaz(at)ofbiz(dot)org>
To: pgsql-jdbc(at)postgresql(dot)org
Cc: Kris Jurka <books(at)ejurka(dot)com>
Subject: Re: Result Set Cursor Patch
Date: 2004-05-05 16:58:23
Message-ID: 6B5DC7FC-9EB5-11D8-95C9-000A95DA1A7C@ofbiz.org (view raw or flat)
Thread:
Lists: pgsql-jdbc
Kris,

Here it is again, I think my IDE reformatted a few classes which caused 
this patch to be bigger then it needed to be. Here it is in its current 
state.

I took the suggestions from the list and implemented the movement of 
position using the MOVE command. This made finding the result set size 
MUCH easier. In addition, I moved all the code related to chunks into a 
new class called ResultChunk which lives in core.

Attached is a tarball which contains the new file as well as the patch. 
This patch uses diff -c rather then diff -u as it was brought to my 
attention as being the preferred format for this project. Let me know 
if this is not correct.

If the formatting is major problem, I can attempt to reformat it to 
desired settings. I will need to know what the "preferred" way is. I've 
noticed there are several different formats used within these classes, 
I could easily run the tree though Jacobe and clean it up. However, 
that may be too big for the list. :)

There is partial support for reverse fetching in this patch, but it 
does not work yet. In this version it is completely disabled so even if 
reverse is requested it will ignore the request and use forward 
fetching instead.

I will fix this when I have some extra time. I don't think the current 
code supports reverse fetching either, so I don't think any current 
functionality is lost.

The code attached does pass the entire test suite without problem.

Please let me know if there are any problems.

-Andy

In response to

Responses

pgsql-jdbc by date

Next:From: Barry LindDate: 2004-05-05 17:39:57
Subject: Re: Database connection problem through JDBC driver
Previous:From: Dave CramerDate: 2004-05-05 16:31:01
Subject: Re: Database connection problem through JDBC driver

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group