Re: pgbench - compute & show latency consistently

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgbench - compute & show latency consistently
Date: 2016-09-21 10:30:27
Message-ID: 68f175fc-9a7d-825b-e573-63d998ced452@iki.fi
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 07/13/2016 11:39 AM, Fabien COELHO wrote:
>>> number of transactions per client: 1000
>>> -latency average = 15.844 ms
>>> +latency average: 15.844 ms
>>> tps = 618.764555 (including connections establishing)
>>
>> I think what you have here is that colons separate input parameters and
>> equal signs separate result output. So I think it's OK the way it is.
>
> Hmmm... Then other measures displayed are not all consistent with this
> theory.
>
> Also there is still the bug under -t which displays a 0 latency.
>
> The attached patch still fixes that and make it consistent the other way
> around, i.e. by using "=" for latency. I switched to use ":" for weight
> which is an input parameter. I let ":" when there is a long sentence to
> describe the figure displayed, more on aesthetical grounds.

Committed, thanks!

- Heikki

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2016-09-21 10:35:04 Re: pgbench - compute & show latency consistently
Previous Message Kuntal Ghosh 2016-09-21 10:07:26 Re: pgbench - compute & show latency consistently