Skip site navigation (1) Skip section navigation (2)

Re: snprintf causes regression tests to fail

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Nicolai Tufar <ntufar(at)gmail(dot)com>,Magnus Hagander <mha(at)sollentuna(dot)net>, pgsql-hackers(at)postgresql(dot)org,pgsql-hackers-win32(at)postgresql(dot)org
Subject: Re: snprintf causes regression tests to fail
Date: 2005-03-02 04:21:24
Message-ID: 6861.1109737284@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-hackers-win32pgsql-patches
Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Tom Lane wrote:
>> Does it help if you flip the order of the snprintf and vsnprintf
>> functions in snprintf.c?

> Yes, it fixes the problem and I have applied the reordering with a
> comment.

Fascinating.

> I will start working on fixing the large fmtpar allocations now.

Quite honestly, this code is not worth micro-optimizing because it
is fundamentally broken.  See my other comments in this thread.

Can we find a BSD-license implementation that follows the spec?

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2005-03-02 04:23:08
Subject: Re: snprintf causes regression tests to fail
Previous:From: Bruce MomjianDate: 2005-03-02 03:23:18
Subject: Re: snprintf causes regression tests to fail

pgsql-patches by date

Next:From: Bruce MomjianDate: 2005-03-02 04:23:08
Subject: Re: snprintf causes regression tests to fail
Previous:From: Bruce MomjianDate: 2005-03-02 03:23:18
Subject: Re: snprintf causes regression tests to fail

pgsql-hackers-win32 by date

Next:From: Bruce MomjianDate: 2005-03-02 04:23:08
Subject: Re: snprintf causes regression tests to fail
Previous:From: Bruce MomjianDate: 2005-03-02 03:23:18
Subject: Re: snprintf causes regression tests to fail

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group