Skip site navigation (1) Skip section navigation (2)

Re: BUG #4566: pg_stop_backup() reports incorrect STOP WAL LOCATION

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
Cc: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Randy Isbell <jisbell(at)cisco(dot)com>, pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #4566: pg_stop_backup() reports incorrect STOP WAL LOCATION
Date: 2009-01-15 16:15:41
Message-ID: 6718.1232036141@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-bugspgsql-docspgsql-hackers
Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> writes:
> Fujii Masao wrote:
>> Only a part of backup
>> history file (the file name including stop wal location) is changed.
>> Currently, the file name is wrong if stop wal location indicates a boundary
>> byte. This would confuse the user, I think.

> Should we change it in HEAD? I'm leaning towards no, on the grounds that 
> tools/people would then have to know the version it's dealing with to 
> interpret the value correctly, and because pg_stop_backup() now waits 
> for the last xlog file to be archived before returning, there's little 
> need to look at that file.

I agree.  It might have been better to define it the other way
originally, but the risks of changing it now outweigh any likely
benefit.

			regards, tom lane

In response to

Responses

pgsql-docs by date

Next:From: Simon RiggsDate: 2009-01-15 17:33:44
Subject: Re: BUG #4566: pg_stop_backup() reports incorrect STOP WALLOCATION
Previous:From: Heikki LinnakangasDate: 2009-01-15 15:23:46
Subject: Re: BUG #4566: pg_stop_backup() reports incorrect STOP WAL LOCATION

pgsql-hackers by date

Next:From: Heikki LinnakangasDate: 2009-01-15 16:16:06
Subject: Re: Hot standby, RestoreBkpBlocks and cleanup locks
Previous:From: Bruce MomjianDate: 2009-01-15 16:11:31
Subject: Re: FWD: Re: Updated backslash consistency patch

pgsql-bugs by date

Next:From: Raymond L. NaseefDate: 2009-01-15 16:50:34
Subject: BUG #4617: JDBC Drivers 8.2/8.3 return no ResultSet
Previous:From: Heikki LinnakangasDate: 2009-01-15 15:23:46
Subject: Re: BUG #4566: pg_stop_backup() reports incorrect STOP WAL LOCATION

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group