| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
| Cc: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Randy Isbell <jisbell(at)cisco(dot)com>, pgsql-bugs(at)postgresql(dot)org |
| Subject: | Re: BUG #4566: pg_stop_backup() reports incorrect STOP WAL LOCATION |
| Date: | 2009-01-15 16:15:41 |
| Message-ID: | 6718.1232036141@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-docs pgsql-hackers |
Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> writes:
> Fujii Masao wrote:
>> Only a part of backup
>> history file (the file name including stop wal location) is changed.
>> Currently, the file name is wrong if stop wal location indicates a boundary
>> byte. This would confuse the user, I think.
> Should we change it in HEAD? I'm leaning towards no, on the grounds that
> tools/people would then have to know the version it's dealing with to
> interpret the value correctly, and because pg_stop_backup() now waits
> for the last xlog file to be archived before returning, there's little
> need to look at that file.
I agree. It might have been better to define it the other way
originally, but the risks of changing it now outweigh any likely
benefit.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Raymond L. Naseef | 2009-01-15 16:50:34 | BUG #4617: JDBC Drivers 8.2/8.3 return no ResultSet |
| Previous Message | Heikki Linnakangas | 2009-01-15 15:23:46 | Re: BUG #4566: pg_stop_backup() reports incorrect STOP WAL LOCATION |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2009-01-15 17:33:44 | Re: BUG #4566: pg_stop_backup() reports incorrect STOP WAL LOCATION |
| Previous Message | Heikki Linnakangas | 2009-01-15 15:23:46 | Re: BUG #4566: pg_stop_backup() reports incorrect STOP WAL LOCATION |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2009-01-15 16:16:06 | Re: Hot standby, RestoreBkpBlocks and cleanup locks |
| Previous Message | Bruce Momjian | 2009-01-15 16:11:31 | Re: FWD: Re: Updated backslash consistency patch |