Skip site navigation (1) Skip section navigation (2)

Re: pg_buffercache tidyup

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers(at)postgresql(dot)org, Mark Kirkwood <markir(at)paradise(dot)net(dot)nz>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: pg_buffercache tidyup
Date: 2006-10-22 17:52:34
Message-ID: 6710.1161539554@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Mark Kirkwood <markir(at)paradise(dot)net(dot)nz> writes:
> This is probably terrible timing, but I noticed Tom had done some nice
> tidying up on pg_freespacemap to eliminate the clumsy conversion to and
> from strings. This patch does a similar thing for pg_buffercache.

Applied --- it is very late in the cycle, but minor code cleanup of
this sort seems pretty safe.

> I did wonder about not showing buffers that are invalid or not in use
> (currently displays all attributes bar the id as NULL). Comments?

I think we should leave it as-is.  You can easily filter the null rows
if you don't want 'em, while they might be handy for certain sorts of
analysis.  Besides, this module has already been out for one release
so we shouldn't change its API on a whim.

			regards, tom lane

In response to

pgsql-hackers by date

Next:From: Marko KreenDate: 2006-10-22 20:25:49
Subject: Re: New CRC algorithm: Slicing by 8
Previous:From: Tom LaneDate: 2006-10-22 17:18:07
Subject: Re: Updates for vcbuild

pgsql-patches by date

Next:From: Thomas HDate: 2006-10-22 23:28:32
Subject: BUG #2712: could not fsync segment: Permission denied
Previous:From: Tom LaneDate: 2006-10-22 17:18:07
Subject: Re: Updates for vcbuild

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group