Skip site navigation (1) Skip section navigation (2)

Re: s_lock.h cleanup

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: s_lock.h cleanup
Date: 2001-01-19 03:49:29
Message-ID: 6698.979876169@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
As long as we're cleaning things up, I would suggest that all the ports
that use gcc assembler be made to declare it uniformly, as

	__asm__ __volatile__ ( ... );

As I read the GCC manual, there's some risk of the asm sections getting
moved around in the program flow if they are not marked volatile.  Also
we oughta be consistent about using the double-underscore keywords IMHO.

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2001-01-19 03:58:34
Subject: Re: s_lock.h cleanup
Previous:From: Tom LaneDate: 2001-01-19 03:17:49
Subject: Re: charset.htm

pgsql-patches by date

Next:From: Bruce MomjianDate: 2001-01-19 03:58:34
Subject: Re: s_lock.h cleanup
Previous:From: Bruce MomjianDate: 2001-01-19 02:58:34
Subject: s_lock.h cleanup

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group