Skip site navigation (1) Skip section navigation (2)

Re: ANSI Compliant Inserts

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Rod Taylor <rbt(at)zort(dot)ca>, pgsql-patches(at)postgresql(dot)org
Subject: Re: ANSI Compliant Inserts
Date: 2002-04-15 03:49:34
Message-ID: 6614.1018842574@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Do you want to argue we should continue allowing it?

No; I'm objecting that there hasn't been adequate discussion about
this change of behavior.

BTW, if the rationale for the change is "ANSI compliance" then the patch
is still wrong.  SQL92 says:

         3) No <column name> of T shall be identified more than once. If the
            <insert column list> is omitted, then an <insert column list>
            that identifies all columns of T in the ascending sequence of
            their ordinal positions within T is implicit.

         5) Let QT be the table specified by the <query expression>. The
            degree of QT shall be equal to the number of <column name>s in
            the <insert column list>.

The patch enforces equality only for the case of an explicit <insert
column list> --- which is the behavior I suggested in the original
comment, but the spec clearly requires an exact match for an implicit
list too.  How tight do we want to get?

In any case this discussion should be taking place someplace more public
than -patches.

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Rod TaylorDate: 2002-04-15 04:00:52
Subject: Re: [PATCHES] ANSI Compliant Inserts
Previous:From: Hiroshi InoueDate: 2002-04-15 03:48:10
Subject: Re: RFC: Restructuring pg_aggregate

pgsql-patches by date

Next:From: Rod TaylorDate: 2002-04-15 04:00:52
Subject: Re: [PATCHES] ANSI Compliant Inserts
Previous:From: Bruce MomjianDate: 2002-04-15 03:40:59
Subject: Re: ANSI Compliant Inserts

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group