Skip site navigation (1) Skip section navigation (2)

async notification patch for dblink

From: "Marcus Kempe" <marcus(at)kempe(dot)cc>
To: pgsql-hackers(at)postgresql(dot)org
Subject: async notification patch for dblink
Date: 2008-11-18 23:47:28
Message-ID: 6534f7ae0811181547v1dc1f096g6222e8273b461606@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
This patch adds the ability to retrieve async notifications using dblink,
via the addition of the function dblink_get_notify.

It is written against cvs head, includes documentation and regression
testing. It compiles, tests and works well.

I would be interested in some feedback on the regression test.
My initial thought was to test the function as thoroughly as possible. So I
perform listen and notify commands within the test to be able to test all
aspects of the code. Even though this works well for me, I get the feeling
that this is not the correct way to do it. I can find no other testing of
the listen/notify functionality in the regression tests, and I imagine this
is for good reason.
If someone would care to explain this, and maybe give a hint about what
amount of testing is appropriate for this fairly trivial patch, it would be
appreciated.

Best regards,

Marcus Kempe

Attachment: dblink_async_notifications-v1.patch
Description: text/x-patch (6.4 KB)

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2008-11-19 03:00:12
Subject: Re: auto_explain contrib moudle
Previous:From: Devrim GÜNDÜZDate: 2008-11-18 21:57:53
Subject: New shapshot RPMs (Nov 18, 2008) are ready for testing

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group