Skip site navigation (1) Skip section navigation (2)

Re: Implementation of SQLCODE and SQLERRM variables for PL/pgSQL

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Pavel Stehule <stehule(at)kix(dot)fsv(dot)cvut(dot)cz>
Cc: Ali Baba <idofyear(at)yahoo(dot)com>, pgsql-hackers(at)postgresql(dot)org,pgsql-patches(at)postgresql(dot)org
Subject: Re: Implementation of SQLCODE and SQLERRM variables for PL/pgSQL
Date: 2005-03-06 20:05:05
Message-ID: 6324.1110139505@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Pavel Stehule <stehule(at)kix(dot)fsv(dot)cvut(dot)cz> writes:
>   This is my second patch, than please will be tolerant :-). For one my 
> project I miss information about exception when I use EXCEPTION WITH 
> OTHERS THEN. I found two Oracle's varaibles SQLCODE and SQLERRM which 
> carry this information.

I think we discussed this last year and decided that it would be a bad
idea to use those names because Oracle's use of them is not exactly
compatible with our error codes and messages.  SQLCODE in particular is
not compatible at all --- it's an integer in Oracle, isn't it?

IIRC we had put off solving this problem until we decided what to do
with RAISE.  There really needs to be some changes in RAISE to allow it
to raise a specific error code rather than always P0001, but exactly
what is still undecided.

Some other problems with your patch: no documentation, and not in
diff -c format.  Plain diff patches are never acceptable because
it's too risky to apply them against files that might have changed
since you started working with them.  Also, it's much easier to
deal with one patch than with a separate diff for each file.
(diff -c -r between an original and a modified directory is one
good way to produce a useful patch.)

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Pavel StehuleDate: 2005-03-06 20:51:49
Subject: Re: Implementation of SQLCODE and SQLERRM variables for
Previous:From: Pavel StehuleDate: 2005-03-06 19:24:38
Subject: Implementation of SQLCODE and SQLERRM variables for PL/pgSQL

pgsql-patches by date

Next:From: Pavel StehuleDate: 2005-03-06 20:51:49
Subject: Re: Implementation of SQLCODE and SQLERRM variables for
Previous:From: Tom LaneDate: 2005-03-06 19:52:08
Subject: Re: Cleaning up unreferenced table files

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group