Simon Riggs <simon(at)2ndQuadrant(dot)com> writes:
> Must not reach consistency before XLOG_BACKUP_RECORD

> When waiting for an XLOG_BACKUP_RECORD the minRecoveryPoint
> will be incorrect, so we must not declare recovery as consistent
> before we have seen the record. Major bug allowing recovery to end
> too early in some cases, allowing people to see inconsistent db.

Is this actually a "major bug fix", or a useless redundant test?
I had thought that that if-statement's check of
XLogRecPtrIsInvalid(ControlFile->backupStartPoint)
was sufficient, because that will keep us from declaring consistency
before we get out of the backup in any case.

			regards, tom lane

In response to

• pgsql: Must not reach consistency before XLOG_BACKUP_RECORD at 2012-12-05 13:28:59 from Simon Riggs

Responses

• Re: pgsql: Must not reach consistency before XLOG_BACKUP_RECORD at 2012-12-05 16:11:00 from Andres Freund

pgsql-committers by date

Next:	From: Andres Freund	Date: 2012-12-05 16:11:00
	Subject: Re: pgsql: Must not reach consistency before XLOG_BACKUP_RECORD
Previous:	From: Simon Riggs	Date: 2012-12-05 13:28:59
	Subject: pgsql: Must not reach consistency before XLOG_BACKUP_RECORD