Skip site navigation (1) Skip section navigation (2)

Re: pgsql: Must not reach consistency before XLOG_BACKUP_RECORD

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Simon Riggs <simon(at)2ndQuadrant(dot)com>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Must not reach consistency before XLOG_BACKUP_RECORD
Date: 2012-12-05 16:04:39
Message-ID: 6317.1354723479@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-committers
Simon Riggs <simon(at)2ndQuadrant(dot)com> writes:
> Must not reach consistency before XLOG_BACKUP_RECORD

> When waiting for an XLOG_BACKUP_RECORD the minRecoveryPoint
> will be incorrect, so we must not declare recovery as consistent
> before we have seen the record. Major bug allowing recovery to end
> too early in some cases, allowing people to see inconsistent db.

Is this actually a "major bug fix", or a useless redundant test?
I had thought that that if-statement's check of
XLogRecPtrIsInvalid(ControlFile->backupStartPoint)
was sufficient, because that will keep us from declaring consistency
before we get out of the backup in any case.

			regards, tom lane


In response to

Responses

pgsql-committers by date

Next:From: Andres FreundDate: 2012-12-05 16:11:00
Subject: Re: pgsql: Must not reach consistency before XLOG_BACKUP_RECORD
Previous:From: Simon RiggsDate: 2012-12-05 13:28:59
Subject: pgsql: Must not reach consistency before XLOG_BACKUP_RECORD

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group