Re: pgsql: Add TCP keepalive support to libpq.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov>
Cc: "Robert Haas" <robertmhaas(at)gmail(dot)com>, "Simon Riggs" <simon(at)2ndquadrant(dot)com>, "Florian Pflug" <fgp(at)phlo(dot)org>, pgsql-hackers(at)postgresql(dot)org, "Robert Haas" <rhaas(at)postgresql(dot)org>
Subject: Re: pgsql: Add TCP keepalive support to libpq.
Date: 2010-06-25 17:02:51
Message-ID: 6245.1277485371@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

"Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov> writes:
> Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> Here's an attempt at rewording the sections so that the
>> information is included in each parameter's description without
>> taking up a whole sentence.
>>
>> Thoughts?

> It makes the point without beating one over the head with it. I
> particularly like the way this patch moves the main point of the
> parameter to the front, with all the conditions under which it might
> be ignored pushed farther back. It reads much better that way, at
> least for me.

Looks good to me too.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2010-06-25 17:08:09 pgsql: Rewrite docs for new libpq keepalive parameters.
Previous Message Robert Haas 2010-06-25 16:55:49 pgsql: Make AIX suggestions about disabling ipv6 more version-sensitive.

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2010-06-25 17:08:31 Re: pgsql: Add TCP keepalive support to libpq.
Previous Message Robert Haas 2010-06-25 15:49:57 Re: Streaming Replication: sql error on standby