Re: MemoryContextStats tweak: show tree structure

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Neil Conway <neilc(at)samurai(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: MemoryContextStats tweak: show tree structure
Date: 2007-08-07 00:56:03
Message-ID: 6163.1186448163@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Neil Conway <neilc(at)samurai(dot)com> writes:
> Previously, MemoryContextStats() simply emitted a line of output for
> each MemoryContext. This is fine, but it makes it difficult to see the
> shape of the MemoryContext hierarchy. Attached is a trivial patch to
> indent each context by "4 * level" spaces, where "level" is the depth of
> the node within the subtree printed by MemoryContextStats().

Seems reasonable except I'd vote for less indentation --- the lines are
too long already. How do you feel about 1 or 2 spaces per level?

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Neil Conway 2007-08-07 01:00:23 Re: MemoryContextStats tweak: show tree structure
Previous Message Neil Conway 2007-08-07 00:48:28 MemoryContextStats tweak: show tree structure