From:
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To:
Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc:
Magnus Hagander <magnus(at)hagander(dot)net>,
PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject:
Re: [COMMITTERS] pgsql: Use symbolic names not octal constants for file permission flags
Date:
2010-12-12 17:37:37
Message-ID:
6112.1292175457@sss.pgh.pa.us (view raw or flat )
Thread:
2010-12-10 22:35:50 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-12-11 13:18:26 from Magnus Hagander <magnus(at)hagander(dot)net>
2010-12-11 15:27:07 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-12-11 16:13:12 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-12-11 16:18:51 from Magnus Hagander <magnus(at)hagander(dot)net>
2010-12-11 16:23:36 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-12-11 16:33:04 from Magnus Hagander <magnus(at)hagander(dot)net>
2010-12-11 16:38:26 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-12-11 16:44:53 from Magnus Hagander <magnus(at)hagander(dot)net>
2010-12-11 16:55:19 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-12-11 16:59:18 from Magnus Hagander <magnus(at)hagander(dot)net>
2010-12-11 17:13:24 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-12-11 17:46:23 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-12-11 17:55:43 from Magnus Hagander <magnus(at)hagander(dot)net>
2010-12-11 18:00:26 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-12-12 16:16:46 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-12-12 17:22:09 from Andrew Dunstan <andrew(at)dunslane(dot)net>
2010-12-12 17:37:37 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-12-13 05:54:21 from Glen Knowles <gknowles(at)ieee(dot)org>
2010-12-13 16:37:57 from Andrew Dunstan <andrew(at)dunslane(dot)net>
Lists:
pgsql-committers pgsql-hackers
Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> On 12/12/2010 11:16 AM, Tom Lane wrote:
>> I put in #define's for these, and it seems to have fixed the MSVC
>> buildfarm members, but cygwin is still broken. How come ... doesn't
>> that port use port/win32.h?
> ITYM Mingw. And yes, it does use port/win32.h; narwhal's log says:
> config.status: linking src/include/port/win32.h to src/include/pg_config_os.h
Oh, I guess the point is that WIN32_ONLY_COMPILER doesn't get defined,
and that block of file-permission-bit #defines is nested inside
#ifdef WIN32_ONLY_COMPILER.
So apparently the issue is that the mingw headers provide some but not
all of those symbols. Which have they got, and how are they defined?
regards, tom lane
In response to
pgsql-hackers by date
Next :From: Tom LaneDate: 2010-12-12 18:43:59Subject : pgsql: Make S_IRGRP etc available in mingw builds as well as MSVC.Previous :From : Andrew DunstanDate : 2010-12-12 17:22:09Subject : Re: [COMMITTERS] pgsql: Use symbolic names not octal constants
for file permission flags
pgsql-committers by date
Next :From: Tom LaneDate: 2010-12-12 18:43:59Subject : pgsql: Make S_IRGRP etc available in mingw builds as well as MSVC.Previous :From : Andrew DunstanDate : 2010-12-12 17:22:09Subject : Re: [COMMITTERS] pgsql: Use symbolic names not octal constants
for file permission flags
