Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: Use symbolic names not octal constants for file permission flags

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Use symbolic names not octal constants for file permission flags
Date: 2010-12-12 17:37:37
Message-ID: 6112.1292175457@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> On 12/12/2010 11:16 AM, Tom Lane wrote:
>> I put in #define's for these, and it seems to have fixed the MSVC
>> buildfarm members, but cygwin is still broken.  How come ... doesn't
>> that port use port/win32.h?

> ITYM Mingw. And yes, it does use port/win32.h; narwhal's log says:
>     config.status: linking src/include/port/win32.h to src/include/pg_config_os.h

Oh, I guess the point is that WIN32_ONLY_COMPILER doesn't get defined,
and that block of file-permission-bit #defines is nested inside
#ifdef WIN32_ONLY_COMPILER.

So apparently the issue is that the mingw headers provide some but not
all of those symbols.  Which have they got, and how are they defined?

			regards, tom lane

In response to

pgsql-hackers by date

Next:From: Tom LaneDate: 2010-12-12 18:43:59
Subject: pgsql: Make S_IRGRP etc available in mingw builds as well as MSVC.
Previous:From: Andrew DunstanDate: 2010-12-12 17:22:09
Subject: Re: [COMMITTERS] pgsql: Use symbolic names not octal constants for file permission flags

pgsql-committers by date

Next:From: Tom LaneDate: 2010-12-12 18:43:59
Subject: pgsql: Make S_IRGRP etc available in mingw builds as well as MSVC.
Previous:From: Andrew DunstanDate: 2010-12-12 17:22:09
Subject: Re: [COMMITTERS] pgsql: Use symbolic names not octal constants for file permission flags

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group