Re: [HACKERS] Zeroing damaged pages

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Simon Riggs <simon(at)2ndquadrant(dot)com>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] Zeroing damaged pages
Date: 2006-03-07 01:38:58
Message-ID: 6105.1141695538@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:

> + /* Even if zero_damaged_pages is true, we don't want autovacuum zeroing. */
> + zero_damaged_pages = false;

This is completely incorrect; you need to set the variable via GUC, else
it will still be overridden from postgresql.conf if a SIGHUP arrives.
I believe this would work:

SetConfigOption("zero_damaged_pages", "false",
PGC_SUSET, PGC_S_SESSION);

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2006-03-07 02:29:30 Re: [PATCHES] LDAP auth
Previous Message Tom Lane 2006-03-07 00:14:18 Re: pg.conf re-reading in signal handler or at next return to main loop?

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2006-03-07 03:12:00 Re: [HACKERS] Zeroing damaged pages
Previous Message Bruce Momjian 2006-03-06 22:25:16 Re: [PATCHES] Inherited Constraints