Re: [PATCH] Windows x64 [repost]

From: Tsutomu Yamada <tsutomu(at)sraoss(dot)co(dot)jp>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Tsutomu Yamada <tsutomu(at)sraoss(dot)co(dot)jp>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Windows x64 [repost]
Date: 2010-01-12 11:08:58
Message-ID: 6086.1263294538@srapc2360.sra.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Thank you very much for refining patch.
I thought there is no missing part.

Magnus Hagander <magnus(at)hagander(dot)net> wrote:
> On Fri, Dec 4, 2009 at 11:42, Tsutomu Yamada <tsutomu(at)sraoss(dot)co(dot)jp> wrote:
> > The following patches support Windows x64.
> >
> > 1) use intptr_t for Datum and pointer macros. (to support Windows LLP64)
> > almost the same as that post before.
> > http://archives.postgresql.org/pgsql-hackers/2009-06/threads.php#01364
> >
> > 2) use appropriate macro and datatypes for Windows API.
> > enables more than 32bits shared memory.
> >
> > 3) Build scripts for MSVC, this came from
> > http://archives.postgresql.org/pgsql-hackers/2008-07/msg00440.php
> > add new parameters to config.pl.
> > You need define "platform" to "x64" for 64bit programs.
>
> I have now applied this, with some extensive refactoring and
> extension. But all parts in this one should be in now, so if you are
> missing something, please let me know :-)
>
> > I was checked where the string converted with "%ld" is used.
> > An especially fatal part is not found excluding one of plperl.
>
> I have not looked at the plperl stuff yet. I'd appreciate a comment
> from someone who knows plperl :-) Andrew, maybe?

It has already been dealt as followed.
# Thanks, I dit not notice the part of pltcl.

Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> I think I dealt with that already, if Tsutomu-san is speaking of the
> prepared-query hash table keys in plperl and pltcl.

--
Tsutomu Yamada
SRA OSS, Inc. Japan

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Chernow 2010-01-12 13:05:01 Re: Typed tables
Previous Message Andreas Joseph Krogh 2010-01-12 10:18:52 Re: NOT NULL violation and error-message