Skip site navigation (1) Skip section navigation (2)

Re: plperl message style on newly added messages

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: plperl message style on newly added messages
Date: 2010-02-15 15:10:57
Message-ID: 603c8f071002150710o6bd7e23eya42ffedfbf516363@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
On Mon, Feb 15, 2010 at 10:02 AM, Alvaro Herrera
<alvherre(at)commandprompt(dot)com> wrote:
> I notice that the new plperl error messages are somewhat out of line of
> our usual style:
>
>            ereport(ERROR,
>                    (errcode(ERRCODE_INTERNAL_ERROR),
>                        errmsg("while executing utf8fix"),
>                        errdetail("%s", strip_trailing_ws(SvPV_nolen(ERRSV))) ));
>
> I think the errdetail field should really be errmsg, and the errdetail
> should be errcontext.
>
> There are several messages like this.
>
> Should this be fixed?

Yes.

...Robert

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2010-02-15 15:15:17
Subject: Re: pg_dump sort order for functions
Previous:From: Robert HaasDate: 2010-02-15 15:08:10
Subject: Re: TCP keepalive support for libpq

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group