| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com>, Teodor Sigaev <teodor(at)sigaev(dot)ru>, Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>, tomas(at)tuxteam(dot)de, "Ragi Y(dot) Burhum" <rburhum(at)gmail(dot)com>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: knngist patch support |
| Date: | 2010-02-14 18:08:47 |
| Message-ID: | 603c8f071002141008x220c10d8uc81da02ed39ec911@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Feb 14, 2010 at 12:24 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> OK. In that case, any objections to my applying the attached patch,
>> which I believe implements this as you suggested?
>
> Um, did you test this version? It looks like the macros are still
> defined according to the idea that SearchSysCache takes five arguments.
You are correct. I realized that this morning while I was shaving.
Sorry about that.
> Also, I'd suggest adding explicit comments to syscache.h suggesting
> that SearchSysCache etc are meant to be called via the macros
> rather than directly.
Good idea.
> I didn't check all the individual calls, but it looks generally
> sane except for those points.
Will fix and commit.
...Robert
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Josh Berkus | 2010-02-14 18:33:16 | Re: CommitFest Status Summary - 2010-02-14 |
| Previous Message | Tom Lane | 2010-02-14 17:52:52 | Re: CommitFest Status Summary - 2010-02-14 |