From:
Robert Haas <robertmhaas(at)gmail(dot)com>
To:
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc:
Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com>, Teodor Sigaev <teodor(at)sigaev(dot)ru>, Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>, tomas(at)tuxteam(dot)de, "Ragi Y(dot) Burhum" <rburhum(at)gmail(dot)com>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject:
Re: knngist patch support
Date:
2010-02-14 04:05:36
Message-ID:
603c8f071002132005u4b259123m4a5e54603e0aebc3@mail.gmail.com (view raw or flat )
Thread:
2010-02-11 00:49:59 from "Ragi Y(dot) Burhum" <rburhum(at)gmail(dot)com>
2010-02-11 05:31:20 from tomas(at)tuxteam(dot)de
2010-02-11 06:16:09 from Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>
2010-02-11 06:49:56 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-02-11 08:00:20 from Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>
2010-02-11 13:18:23 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-02-11 14:51:46 from Greg Stark <gsstark(at)mit(dot)edu>
2010-02-11 15:23:10 from Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>
2010-02-11 15:18:46 from Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>
2010-02-12 18:14:46 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-02-12 20:44:58 from Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>
2010-02-12 21:14:51 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-02-12 21:29:26 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-02-13 00:30:43 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-02-13 02:10:19 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-02-13 02:27:09 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-02-13 02:45:18 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-02-13 02:57:33 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-02-13 03:10:30 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-02-13 03:18:38 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-02-13 03:38:18 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-02-13 03:39:17 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-02-13 18:13:19 from Teodor Sigaev <teodor(at)sigaev(dot)ru>
2010-02-13 18:28:48 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-02-13 18:31:44 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-02-13 19:03:16 from Joshua Tolley <eggyknap(at)gmail(dot)com>
2010-02-13 19:12:22 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-02-13 19:21:01 from Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com>
2010-02-13 20:02:36 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-02-13 20:48:38 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-02-13 20:50:57 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-02-13 20:59:27 from Teodor Sigaev <teodor(at)sigaev(dot)ru>
2010-02-13 19:18:56 from Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com>
2010-02-13 19:38:34 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-02-13 20:52:45 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-02-13 20:58:58 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-02-14 03:26:55 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-02-14 03:40:23 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-02-14 04:05:36 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-02-14 17:24:59 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-02-14 18:08:47 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-02-13 21:20:25 from Dimitri Fontaine <dfontaine(at)hi-media(dot)com>
2010-02-14 16:01:28 from Yeb Havinga <yebhavinga(at)gmail(dot)com>
2010-02-14 00:12:44 from Jeff Davis <pgsql(at)j-davis(dot)com>
2010-02-11 16:37:56 from Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>
2010-02-11 07:28:25 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-02-11 07:45:37 from "Ragi Y(dot) Burhum" <rburhum(at)gmail(dot)com>
2010-02-11 08:38:01 from Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>
2010-02-11 13:01:25 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-02-11 14:19:14 from Dimitri Fontaine <dfontaine(at)hi-media(dot)com>
2010-02-11 21:39:25 from tomas(at)tuxteam(dot)de
Lists:
pgsql-hackers
On Sat, Feb 13, 2010 at 10:40 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> ...
>> 2. Modify pg_amop by adding a new column amopcategory, probably either
>> int2 or maybe even just char.
>> ...
>> I'm not prepared to endorse doing #3 in core for 9.0, but I wonder if
>> it would be feasible to think about doing #1 and #2 and putting
>> something into contrib for #3.
>
> No, we are not touching the system catalogs for this in 9.0, much less
> fooling with any planner logic. If it had been submitted a few months
> earlier that could have happened, but we are barely 48 hours away from
> alpha freeze. The only part of this that I think can even be considered
> at this point is to do a backwards-compatible source code upgrade that
> will decouple the various call sites from knowledge of exactly how many
> key columns the syscaches allow. And even that is not for the benefit
> of this feature; it's mainly to minimize breakage of other patches
> that will be developed between now and whenever knngist does land.
> (IOW, I agree with your point that making the call syntax change now
> is the least painful time to do that.)
OK. In that case, any objections to my applying the attached patch,
which I believe implements this as you suggested?
...Robert
In response to
Responses
pgsql-hackers by date
Next :From: Robert HaasDate: 2010-02-14 04:34:51Subject : CommitFest Status Summary - 2010-02-14Previous :From : Tom LaneDate : 2010-02-14 03:40:23Subject : Re: knngist patch support
