Re: Patch: Remove gcc dependency in definition of inline functions

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Kurt Harriman <harriman(at)acm(dot)org>, pgsql-hackers(at)postgresql(dot)org, Peter Eisentraut <peter_e(at)gmx(dot)net>
Subject: Re: Patch: Remove gcc dependency in definition of inline functions
Date: 2010-02-13 02:36:44
Message-ID: 603c8f071002121836n412cb067qb84c6992b3eda563@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Feb 12, 2010 at 9:35 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> On Wed, Feb 10, 2010 at 5:53 PM, Kurt Harriman <harriman(at)acm(dot)org> wrote:
>>> Revised patch is attached (4th edition).
>
>> This looks generally sane to me, though it seems entirely imaginable
>> that it might break something, somewhere, for somebody... in which
>> case I suppose we'll adjust as needed.
>
> Looks sane to me too -- committed.  We'll soon see what the buildfarm
> thinks (though the number of non-gcc buildfarm members is depressingly
> small).

I can't feel bad about the near-ubiquity of gcc... life would be a
lot harder if it were otherwise.

...Robert

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2010-02-13 02:45:18 Re: knngist patch support
Previous Message Tom Lane 2010-02-13 02:35:29 Re: Patch: Remove gcc dependency in definition of inline functions