| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Boszormenyi Zoltan <zb(at)cybertec(dot)at> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Hans-Juergen Schoenig <hs(at)cybertec(dot)at>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Provide rowcount for utility SELECTs |
| Date: | 2010-02-12 17:34:21 |
| Message-ID: | 603c8f071002120934t3476e01evd4686ad2b343f640@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Feb 12, 2010 at 10:48 AM, Boszormenyi Zoltan <zb(at)cybertec(dot)at> wrote:
> I added a small change to protocol.sgml for the
> "CommandComplete" message describing the change.
> Is it enough?
Ah, I didn't even see that that section needed to be updated. Good
catch. I'd suggest the following wording:
For a <command>SELECT</command> or <command>CREATE TABLE AS</command>
command, the tag is SELECT rows... [and the rest as you have it]
We should probably also retitle that section from "Retrieving Result
Information for Other Commands" to "Retrieving Other Result
Information" and adjust the text of the opening sentence similarly.
Also I think you need to update the docs for PQcmdtuples to mention
that it not works for SELECT and CTAS.
...Robert
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2010-02-12 17:47:19 | Re: review: More frame options in window functions |
| Previous Message | Dimitri Fontaine | 2010-02-12 17:25:02 | Re: Re: [COMMITTERS] pgsql: Make standby server continuously retry restoring the next WAL |