Skip site navigation (1)
Skip section navigation (2)
Peripheral Links
Re: [CFReview] Red-Black Tree
2010/2/10 Teodor Sigaev <teodor(at)sigaev(dot)ru>:
>> So suppose at this point that step is the largest integer that can be
>> represented...
>>>
>>> ! step ++;
>>
>> Boom.
>>>
>>> ! step>>= 1;
>
> step>>= 1;
> step ++'
>
> Unboom?
Yeah, that'll work.
>>> !
>>> ! while(step> 0) {
>>> ! int i;
>>>
>>> ! for (i = step-1; i< nentry; i += 2 * step)
>>
>> And similarly here... if nentry is greater than maxint/2, then i += 2
>> * step will overflow, no?
>
> Agree, so
> for (i = step - 1; i < nentry && i >= 0; i += step << 1 /* *2 */)
I don't think you should do it this way. I can't immediately say
whether it's safe on all platforms, but it's certainly not clear.
Just put the test at the bottom of the loop the way I did it (after
fixing whatever I screwed up).
> Also, rb_free is removed per Tom's comment. Can I commit the patch?
Pending the above, go for it.
...Robert
In response to
- Re: [CFReview] Red-Black Tree at 2010-02-10 18:40:16 from Teodor Sigaev
pgsql-hackers by date
Next: From: Robert Haas Date: 2010-02-10 18:57:13 Subject: Re: Some belated patch review for "Buffers" explain analyze patch Previous: From: Alvaro Herrera Date: 2010-02-10 18:56:14 Subject: Re: [CFReview] Red-Black Tree