From:
Robert Haas <robertmhaas(at)gmail(dot)com>
To:
Dimitri Fontaine <dfontaine(at)hi-media(dot)com>
Cc:
Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Marko Tiikkaja <marko(dot)tiikkaja(at)cs(dot)helsinki(dot)fi>, Josh Berkus <josh(at)agliodbs(dot)com>, pgsql-hackers(at)postgresql(dot)org, David Fetter <david(at)fetter(dot)org>
Subject:
Re: damage control mode
Date:
2010-02-08 16:54:49
Message-ID:
603c8f071002080854m6ff551bfj4387677a35ebf54@mail.gmail.com (view raw or flat )
Thread:
2010-01-08 01:57:15 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-01-08 02:09:13 from David Fetter <david(at)fetter(dot)org>
2010-01-08 02:18:32 from Stephen Frost <sfrost(at)snowman(dot)net>
2010-01-08 09:02:23 from Dimitri Fontaine <dfontaine(at)hi-media(dot)com>
2010-01-08 09:05:51 from Magnus Hagander <magnus(at)hagander(dot)net>
2010-01-08 09:25:25 from Dimitri Fontaine <dfontaine(at)hi-media(dot)com>
2010-01-08 17:16:23 from "David E(dot) Wheeler" <david(at)kineticode(dot)com>
2010-01-09 00:48:41 from Peter Eisentraut <peter_e(at)gmx(dot)net>
2010-01-09 02:01:09 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-01-09 13:07:12 from Dimitri Fontaine <dfontaine(at)hi-media(dot)com>
2010-01-09 13:46:20 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-01-09 15:31:00 from Dimitri Fontaine <dfontaine(at)hi-media(dot)com>
2010-01-10 11:52:23 from Simon Riggs <simon(at)2ndQuadrant(dot)com>
2010-01-09 14:33:47 from Peter Eisentraut <peter_e(at)gmx(dot)net>
2010-01-09 19:12:40 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-01-09 21:01:07 from Peter Eisentraut <peter_e(at)gmx(dot)net>
2010-01-09 21:32:29 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-01-10 06:28:46 from Robert Treat <xzilla(at)users(dot)sourceforge(dot)net>
2010-01-10 06:38:07 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-01-10 07:09:16 from Robert Treat <xzilla(at)users(dot)sourceforge(dot)net>
2010-01-10 10:31:13 from Magnus Hagander <magnus(at)hagander(dot)net>
2010-01-10 12:55:09 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-01-10 12:53:35 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-01-12 00:54:00 from Bruce Momjian <bruce(at)momjian(dot)us>
2010-01-12 01:03:25 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-01-12 01:52:23 from Josh Berkus <josh(at)agliodbs(dot)com>
2010-01-10 10:29:03 from Magnus Hagander <magnus(at)hagander(dot)net>
2010-01-10 17:53:35 from Peter Eisentraut <peter_e(at)gmx(dot)net>
2010-01-10 23:24:42 from Josh Berkus <josh(at)agliodbs(dot)com>
2010-01-11 03:13:32 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-01-10 04:54:04 from Josh Berkus <josh(at)agliodbs(dot)com>
2010-01-10 10:27:01 from Magnus Hagander <magnus(at)hagander(dot)net>
2010-01-10 13:02:21 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-01-10 13:21:43 from Andrew Dunstan <andrew(at)dunslane(dot)net>
2010-01-12 00:50:23 from Bruce Momjian <bruce(at)momjian(dot)us>
2010-01-12 00:52:51 from "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>
2010-01-12 01:14:04 from David Fetter <david(at)fetter(dot)org>
2010-01-12 02:19:44 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-01-12 02:30:06 from Bruce Momjian <bruce(at)momjian(dot)us>
2010-01-12 02:35:38 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-01-12 02:45:01 from Bruce Momjian <bruce(at)momjian(dot)us>
2010-01-12 02:50:45 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-01-12 02:54:49 from Bruce Momjian <bruce(at)momjian(dot)us>
2010-01-12 04:15:55 from Greg Smith <greg(at)2ndquadrant(dot)com>
2010-01-12 04:44:30 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-01-12 09:19:59 from Dimitri Fontaine <dfontaine(at)hi-media(dot)com>
2010-01-12 17:52:20 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-01-12 17:56:25 from "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>
2010-01-12 18:05:02 from "Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov>
2010-01-12 17:58:48 from Bruce Momjian <bruce(at)momjian(dot)us>
2010-01-12 18:32:13 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-01-12 07:12:50 from Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
2010-01-12 08:01:47 from David Fetter <david(at)fetter(dot)org>
2010-01-08 02:11:16 from Andrew Dunstan <andrew(at)dunslane(dot)net>
2010-01-08 02:41:01 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-01-08 16:44:12 from Bruce Momjian <bruce(at)momjian(dot)us>
2010-01-08 17:01:34 from "Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov>
2010-01-08 17:04:12 from "Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov>
2010-01-08 17:14:53 from Stephen Frost <sfrost(at)snowman(dot)net>
2010-01-08 17:31:47 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-01-08 18:07:16 from Bruce Momjian <bruce(at)momjian(dot)us>
2010-01-08 18:13:49 from Andres Freund <andres(at)anarazel(dot)de>
2010-01-08 18:26:19 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-01-08 18:29:01 from Bruce Momjian <bruce(at)momjian(dot)us>
2010-01-08 18:34:27 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-01-08 18:38:20 from Bruce Momjian <bruce(at)momjian(dot)us>
2010-01-08 18:55:39 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-01-08 20:43:33 from Bruce Momjian <bruce(at)momjian(dot)us>
2010-01-08 02:39:58 from Jeff Davis <pgsql(at)j-davis(dot)com>
2010-01-08 20:23:46 from Josh Berkus <josh(at)agliodbs(dot)com>
2010-01-08 03:20:37 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-01-08 03:38:30 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-01-08 03:51:01 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-01-08 04:00:57 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-01-08 07:17:59 from Greg Smith <greg(at)2ndquadrant(dot)com>
2010-01-08 20:28:08 from Josh Berkus <josh(at)agliodbs(dot)com>
2010-02-07 05:27:22 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-02-07 06:38:00 from Josh Berkus <josh(at)agliodbs(dot)com>
2010-02-07 12:53:41 from Tim Bunce <Tim(dot)Bunce(at)pobox(dot)com>
2010-02-07 13:27:13 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-02-07 14:56:32 from Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>,
Mark Cave-Ayland <mark(dot)cave-ayland(at)siriusit(dot)co(dot)uk>,
Teodor Sigaev <teodor(at)sigaev(dot)ru>
2010-02-07 19:13:04 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-02-07 20:15:51 from Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>
2010-02-08 04:41:31 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-02-08 20:11:51 from Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>
2010-02-08 20:20:41 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-02-07 07:05:21 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-02-07 13:15:56 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-02-07 20:37:56 from Josh Berkus <josh(at)agliodbs(dot)com>
2010-02-07 20:48:34 from Marko Tiikkaja <marko(dot)tiikkaja(at)cs(dot)helsinki(dot)fi>
2010-02-07 21:03:41 from Dimitri Fontaine <dfontaine(at)hi-media(dot)com>
2010-02-07 21:34:26 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-02-07 21:54:54 from Dimitri Fontaine <dfontaine(at)hi-media(dot)com>
2010-02-08 04:11:55 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-02-08 15:25:36 from Alvaro Herrera <alvherre(at)commandprompt(dot)com>
2010-02-08 15:31:57 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-02-08 16:47:23 from Dimitri Fontaine <dfontaine(at)hi-media(dot)com>
2010-02-08 16:54:49 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-02-08 17:34:54 from Josh Berkus <josh(at)agliodbs(dot)com>
2010-02-08 17:45:13 from "David E(dot) Wheeler" <david(at)kineticode(dot)com>
2010-02-08 18:38:56 from Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>
2010-02-08 04:23:18 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-02-08 18:01:56 from Merlin Moncure <mmoncure(at)gmail(dot)com>
2010-02-08 10:06:36 from Magnus Hagander <magnus(at)hagander(dot)net>
Lists:
pgsql-hackers
On Mon, Feb 8, 2010 at 11:47 AM, Dimitri Fontaine
<dfontaine(at)hi-media(dot)com> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> On Mon, Feb 8, 2010 at 10:25 AM, Alvaro Herrera
>> <alvherre(at)commandprompt(dot)com> wrote:
>>> Eh? Previously we allowed code to go in with documentation to be
>>> written after feature freeze. Is this no longer acceptable?
>>
>> I don't think we usually allow that for minor features. For big
>> things, it's probably more reasonable, but I would think that at least
>> some effort should be put in before commit. I'm new here, though, so
>> I might be all wet. But I wouldn't want to commit ten patches without
>> documentation and then have someone come back and say, OK, you
>> committed 'em, you write the docs. Or else no one comes back, and I
>> forget, and it never gets done.
>
> Well, traditionnaly, we had Bruce to sort those things out. But in this
> case the problem is not so much about writing documentation than
> deciding where to put it and what to explain exactly. I think.
>
> Anyway saying the patch can not be considered by a commiter for only
> lack of complete documentation is not a policy here, IME. It can happen,
> but I would consider it bad news if it were to become a way to force the
> release timeframe. What is hard is doing *good* compromises.
Of course any committer can consider any patch whenever they like,
regardless of how it is marked on commitfest.postgresql.org , right?
And there has been no shortage of committers doing just that; 80%+ of
the reviews for this CommitFest were done by committers. But I'm not
going to spend the time to write the docs for somebody else's patch
unless I really care about seeing it go in; other committers are free
to do as they like, of course.
...Robert
In response to
pgsql-hackers by date
Next :From: David E. WheelerDate: 2010-02-08 17:07:04Subject : Re: Pathological regexp matchPrevious :From : Dimitri FontaineDate : 2010-02-08 16:47:23Subject : Re: damage control mode
